Bug 252869 - audio/fdk-aac: Update to latest commit as of 2021-01-20
Summary: audio/fdk-aac: Update to latest commit as of 2021-01-20
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL: https://github.com/mstorsjo/fdk-aac/
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-20 20:59 UTC by Daniel Engberg
Modified: 2022-08-06 08:40 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bofh)

Attachments
Patch for fdk-aac (1.93 KB, patch)
2021-01-20 20:59 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-01-20 20:59:02 UTC 
Created attachment 221774 [details]
Patch for fdk-aac

Update fdk-aac to latest commit as of 2021-01-20
Contains various small fixes (see upstream commit log)
Switch to CMake

Compile and run-tested on FreeBSD 13.0-CURRENT main-c1-g63f93c7e1 (amd64) (make, make check-plist) tested with ffmpeg
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-01-20 21:01:38 UTC 
System: i7-3770 @ 4.1Ghz, 6 cores HyperV VM running 13-CURRENT

Compilation, I know it's not completely fair but to get an idea

Current version in tree
====> Compressing man pages (compress-man)
        19.09s real             1m20.15s user           2.93s sys

New version using CMake
====> Compressing man pages (compress-man)
        45.15s real             2m54.52s user           32.32s sys

Encoding

Current version in tree
/usr/bin/time -h ffmpeg -i sample.wav -c:a libfdk_aac -b:a 192k new.m4a
size=   13875kB time=00:09:47.67 bitrate= 193.4kbits/s speed=70.2x
video:0kB audio:13775kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.727592%
        8.39s real              8.28s user              0.06s sys

New version
/usr/bin/time -h ffmpeg -i sample.wav -c:a libfdk_aac -b:a 192k new.m4a
size=   13875kB time=00:09:47.67 bitrate= 193.4kbits/s speed=74.8x
video:0kB audio:13775kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.727592%
        7.87s real              7.80s user              0.03s sys
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-01-20 21:03:07 UTC 
Sorry, the compilation got switched... :/

Current version in tree
====> Compressing man pages (compress-man)
        45.15s real             2m54.52s user           32.32s sys

New version using CMake
====> Compressing man pages (compress-man)
        19.09s real             1m20.15s user           2.93s sys
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-01-20 21:07:01 UTC 
...and of course encoding too (new version is slightly slower)

Current version in tree
/usr/bin/time -h ffmpeg -i sample.wav -c:a libfdk_aac -b:a 192k new.m4a
size=   13875kB time=00:09:47.67 bitrate= 193.4kbits/s speed=74.8x
video:0kB audio:13775kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.727592%
        7.87s real              7.80s user              0.03s sys

New version
/usr/bin/time -h ffmpeg -i sample.wav -c:a libfdk_aac -b:a 192k new.m4a
size=   13875kB time=00:09:47.67 bitrate= 193.4kbits/s speed=70.2x
video:0kB audio:13775kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.727592%
        8.39s real              8.28s user              0.06s sys

I apologize, I shouldn't submit patches while being distracted.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-01-24 14:11:49 UTC 
A commit references this bug:

Author: bofh
Date: Sun Jan 24 14:11:09 UTC 2021
New revision: 562476
URL: https://svnweb.freebsd.org/changeset/ports/562476

Log:
  audio/fdk-aac: Update version 2.0.1=>2.0.1-568

  - Switch MASTER_SITES to GH

  PR:	252869
  Submitted by:	daniel.engberg.lists@pyret.net

Changes:
  head/audio/fdk-aac/Makefile
  head/audio/fdk-aac/distinfo
  head/audio/fdk-aac/pkg-plist