Created attachment 221774 [details] Patch for fdk-aac Update fdk-aac to latest commit as of 2021-01-20 Contains various small fixes (see upstream commit log) Switch to CMake Compile and run-tested on FreeBSD 13.0-CURRENT main-c1-g63f93c7e1 (amd64) (make, make check-plist) tested with ffmpeg Poudriere testport OK 12.2-RELEASE (amd64) Poudriere testport OK 11.4-RELEASE (amd64)
System: i7-3770 @ 4.1Ghz, 6 cores HyperV VM running 13-CURRENT Compilation, I know it's not completely fair but to get an idea Current version in tree ====> Compressing man pages (compress-man) 19.09s real 1m20.15s user 2.93s sys New version using CMake ====> Compressing man pages (compress-man) 45.15s real 2m54.52s user 32.32s sys Encoding Current version in tree /usr/bin/time -h ffmpeg -i sample.wav -c:a libfdk_aac -b:a 192k new.m4a size= 13875kB time=00:09:47.67 bitrate= 193.4kbits/s speed=70.2x video:0kB audio:13775kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.727592% 8.39s real 8.28s user 0.06s sys New version /usr/bin/time -h ffmpeg -i sample.wav -c:a libfdk_aac -b:a 192k new.m4a size= 13875kB time=00:09:47.67 bitrate= 193.4kbits/s speed=74.8x video:0kB audio:13775kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.727592% 7.87s real 7.80s user 0.03s sys
Sorry, the compilation got switched... :/ Current version in tree ====> Compressing man pages (compress-man) 45.15s real 2m54.52s user 32.32s sys New version using CMake ====> Compressing man pages (compress-man) 19.09s real 1m20.15s user 2.93s sys
...and of course encoding too (new version is slightly slower) Current version in tree /usr/bin/time -h ffmpeg -i sample.wav -c:a libfdk_aac -b:a 192k new.m4a size= 13875kB time=00:09:47.67 bitrate= 193.4kbits/s speed=74.8x video:0kB audio:13775kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.727592% 7.87s real 7.80s user 0.03s sys New version /usr/bin/time -h ffmpeg -i sample.wav -c:a libfdk_aac -b:a 192k new.m4a size= 13875kB time=00:09:47.67 bitrate= 193.4kbits/s speed=70.2x video:0kB audio:13775kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.727592% 8.39s real 8.28s user 0.06s sys I apologize, I shouldn't submit patches while being distracted.
A commit references this bug: Author: bofh Date: Sun Jan 24 14:11:09 UTC 2021 New revision: 562476 URL: https://svnweb.freebsd.org/changeset/ports/562476 Log: audio/fdk-aac: Update version 2.0.1=>2.0.1-568 - Switch MASTER_SITES to GH PR: 252869 Submitted by: daniel.engberg.lists@pyret.net Changes: head/audio/fdk-aac/Makefile head/audio/fdk-aac/distinfo head/audio/fdk-aac/pkg-plist