Created attachment 221791 [details] tiemu3-3.03_10.patch * Update Makefile in the following ways: - Bump PORTREVISION - Add LIB_DEPENDS that stage-qa says should be there - Add USE_GNOME that stage-qa says should be there - Add localbase to USES and remove the parts setting those in CPPFLAGS and LDFLAGS - Correct the linker flag of -export-dynamic to -Wl,-E instead As an aside, I have been getting build failures from pkg-fallout on this port on 13-i386. The latest build log is at http://beefy17.nyi.freebsd.org/data/main-i386-default/p562159_s5bd565855a/logs/tiemu3-3.03_9.log according to the email. I do not know the cause of this as I do not encounter it locally with my 12-i386 or 11-i386 poudriere jails, so I do not have anything local that can point my in a direction as to why this is happening. Tested in poudriere for 11-i386, 11-amd64, 12-i386 and 12-amd64. Passed portlint for the most part (it complains about files/patch-man_Makefile.in not being generated by make makepatch, but the patch works so I do not see any reason to touch it).
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/245069863
Great job! A few hints as reported by portclippy: # USES block USES +USE_GNOME +USE_SDL # Configure block GNU_CONFIGURE +CONFIGURE_ARGS -USE_GNOME -USE_SDL # CFLAGS/CXXFLAGS/LDFLAGS block LDFLAGS -CONFIGURE_ARGS Also it would be nice if LIB_DEPENDS were sorted alphabetically. Would you like to make this changes?
Created attachment 221801 [details] tiemu3-3.03_10.patch Sure thing, here is a replacement patch that does all of that.
Committed, Thanks! Note: builds fine in {11.4,12.2}{amd64,i386} and 13-current amd64. Unfortunately I can not test in current i386
A commit references this bug: Author: fernape Date: Fri Jan 22 10:10:56 UTC 2021 New revision: 562291 URL: https://svnweb.freebsd.org/changeset/ports/562291 Log: emulators/tiemu3: Modernize Makefile and fix issues * Add LIB_DEPENDS that stage-qa says should be there * Add USE_GNOME that stage-qa says should be there * Add localbase to USES and remove the parts setting those in CPPFLAGS and LDFLAGS * Correct the linker flag of -export-dynamic to -Wl,-E instead PR: 252890 Submitted by: cyberbotx@cyberbotx.com (maintainer) Changes: head/emulators/tiemu3/Makefile head/emulators/tiemu3/files/patch-man_Makefile.in