Bug 253146 - Identical sysctl descriptions for kern.proc.proc and kern.proc.proc_td
Summary: Identical sysctl descriptions for kern.proc.proc and kern.proc.proc_td
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Ed Maste
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2021-02-01 02:56 UTC by Pau Amma
Modified: 2021-02-10 23:14 UTC (History)
1 user (show)

See Also:
koobs: mfc-stable13+
koobs: mfc-stable12+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pau Amma 2021-02-01 02:56:03 UTC 
% sysctl -ad | grep -i thread
kern.proc.proc: Return process table, no threads
kern.proc.proc_td: Return process table, no threads

Cursory examination of the sysctl declarations (in sys/kern/kern_proc.c) suggests the latter should be something like "Return process table, including threads". Present in at least 12.1 and 14-current.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-02-02 22:01:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=edc374e7c41d3d9e28e0b3a76bc9ed021d7db571

commit edc374e7c41d3d9e28e0b3a76bc9ed021d7db571
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-02-02 21:55:51 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-02-02 22:00:05 +0000

    Correct description for kern.proc.proc_td

    kern.proc.proc_td returns the process table with an entry for each
    thread.  Previously the description included "no threads", presumably
    a cut-and-pasteo in 2648efa621748.

    Description suggested by PauAmma.

    PR:             253146
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation

 sys/kern/kern_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-02-05 00:28:24 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=dbe043d42cda38e7f4186f0c0ed39569b713f05b

commit dbe043d42cda38e7f4186f0c0ed39569b713f05b
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-02-02 21:55:51 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-02-05 00:26:10 +0000

    Correct description for kern.proc.proc_td

    kern.proc.proc_td returns the process table with an entry for each
    thread.  Previously the description included "no threads", presumably
    a cut-and-pasteo in 2648efa621748.

    Description suggested by PauAmma.

    PR:             253146
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit edc374e7c41d3d9e28e0b3a76bc9ed021d7db571)

 sys/kern/kern_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-02-05 02:53:48 UTC 
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=7523914d08f9afba1b15f051bc34245cd551c725

commit 7523914d08f9afba1b15f051bc34245cd551c725
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-02-02 21:55:51 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-02-05 02:51:45 +0000

    Correct description for kern.proc.proc_td

    kern.proc.proc_td returns the process table with an entry for each
    thread.  Previously the description included "no threads", presumably
    a cut-and-pasteo in 2648efa621748.

    Description suggested by PauAmma.

    PR:             253146
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit edc374e7c41d3d9e28e0b3a76bc9ed021d7db571)

 sys/kern/kern_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-02-10 17:11:13 UTC 
A commit in branch releng/13.0 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=bfb217a826bdd920ddeef74f925944b911b69f89

commit bfb217a826bdd920ddeef74f925944b911b69f89
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2021-02-02 21:55:51 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2021-02-10 17:10:01 +0000

    Correct description for kern.proc.proc_td

    kern.proc.proc_td returns the process table with an entry for each
    thread.  Previously the description included "no threads", presumably
    a cut-and-pasteo in 2648efa621748.

    Description suggested by PauAmma.

    PR:             253146
    Approved by:    re (gjb)
    Sponsored by:   The FreeBSD Foundation

    (cherry picked from commit edc374e7c41d3d9e28e0b3a76bc9ed021d7db571)
    (cherry picked from commit dbe043d42cda38e7f4186f0c0ed39569b713f05b)

 sys/kern/kern_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Ed Maste freebsd_committer freebsd_triage 2021-02-10 17:12:16 UTC 
Thank you for the submission
Now merged to stable branches and releng/13.0
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2021-02-10 23:14:36 UTC 
^Triage: Track merges