Bug 253206 - deskutils/lumina-screenshot WWW home page
Summary: deskutils/lumina-screenshot WWW home page
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/lumina-desktop/lum...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-03 08:49 UTC by Graham Perrin
Modified: 2024-07-15 12:54 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (lbartoletti)


Attachments
pkg-descr unified diff (368 bytes, patch)
2021-11-09 23:09 UTC, Jason W. Bacon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2021-02-03 08:49:47 UTC
https://www.freshports.org/deskutils/lumina-screenshot/#description currently offers: 

* https://lumina-desktop.org/

That's an ideal home page for a different (broader) port. 

For Lumina Screenshot specifically, might this page be better?

* https://github.com/lumina-desktop/lumina/tree/master/src-qt5/desktop-utils/lumina-screenshot
Comment 1 Loïc Bartoletti freebsd_committer freebsd_triage 2021-06-18 06:42:07 UTC
Indeed, each modules can have its own WWW home page. Is it possible to you to submit a patch? Thanks
Comment 2 Jason W. Bacon freebsd_committer freebsd_triage 2021-11-09 23:09:31 UTC
Created attachment 229397 [details]
pkg-descr unified diff

To generate a patch like this, just make the changes and run "git diff" while in /usr/ports.
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-12 18:48:50 UTC
Loic, do you approve the patch?
Comment 4 Jason W. Bacon freebsd_committer freebsd_triage 2024-07-13 12:26:49 UTC
I'm maintaining the Lumina ports now.  I'll have a look at this and any other forgotten PRs ASAP.
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-14 13:23:32 UTC
(In reply to Jason W. Bacon from comment #4)
Oh sorry, indeed.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=df8deb76eab20ee2c07199e6f49c06765fbc3155

commit df8deb76eab20ee2c07199e6f49c06765fbc3155
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:37:11 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:28 +0000

    x11/lumina-coreutils: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 x11/lumina-coreutils/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3b1e379e62f108829ad8f1eb87e5c0cc1d2d2c54

commit 3b1e379e62f108829ad8f1eb87e5c0cc1d2d2c54
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:35:50 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:27 +0000

    deskutils/lumina-screenshot: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 deskutils/lumina-screenshot/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:16 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=74df0bf1f83e2908feba597347d3e9259476896d

commit 74df0bf1f83e2908feba597347d3e9259476896d
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:38:07 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:29 +0000

    x11/lumina: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 x11/lumina/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b28e7f3818d5b3965dbe3ea82d3e616954e10487

commit b28e7f3818d5b3965dbe3ea82d3e616954e10487
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:36:14 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:28 +0000

    deskutils/lumina-textedit: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 deskutils/lumina-textedit/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=65df9e8360f75b997d397eecbde90019a96eb39f

commit 65df9e8360f75b997d397eecbde90019a96eb39f
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:28:09 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:25 +0000

    deskutils/lumina-archiver: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 deskutils/lumina-archiver/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dbe68a5ffc581798d638081e2e06d80f67902359

commit dbe68a5ffc581798d638081e2e06d80f67902359
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:34:35 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:27 +0000

    deskutils/lumina-pdf: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 deskutils/lumina-pdf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 12 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b76f279e47592f304c9e38d08de39a0aa7ad5edb

commit b76f279e47592f304c9e38d08de39a0aa7ad5edb
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:31:31 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:26 +0000

    deskutils/lumina-calculator: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 deskutils/lumina-calculator/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 13 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9b29e4885b0f3e30fe97ab238d3704537b2e04c1

commit 9b29e4885b0f3e30fe97ab238d3704537b2e04c1
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:34:50 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:27 +0000

    deskutils/lumina-photo: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 deskutils/lumina-photo/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 14 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d6b3c0a3b9654051806c2488060c3bd8c0a1761e

commit d6b3c0a3b9654051806c2488060c3bd8c0a1761e
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:34:11 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:27 +0000

    deskutils/lumina-mediaplayer: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 deskutils/lumina-mediaplayer/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 15 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=31c068d1f3205eee9724158d315a030291e735fe

commit 31c068d1f3205eee9724158d315a030291e735fe
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:33:38 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:26 +0000

    deskutils/lumina-fileinfo: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 deskutils/lumina-fileinfo/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 16 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1ae45003027e8196037440815e9b993bd58d1bb2

commit 1ae45003027e8196037440815e9b993bd58d1bb2
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:32:09 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:26 +0000

    deskutils/lumina-fm: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 deskutils/lumina-fm/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 17 commit-hook freebsd_committer freebsd_triage 2024-07-14 20:39:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e14463bc49dbc50871cb42faa0a5b24f39a04e64

commit e14463bc49dbc50871cb42faa0a5b24f39a04e64
Author:     Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2024-07-14 20:36:41 +0000
Commit:     Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2024-07-14 20:38:28 +0000

    x11/lumina-core: More targeted WWW

    https://lumina-desktop.org has no information about components

    PR:             253206
    Reported by:    grahamperrin

 x11/lumina-core/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 18 Jason W. Bacon freebsd_committer freebsd_triage 2024-07-14 20:41:17 UTC
Updated WWW in all the Lumina ports.

I did not bump PORTREVISION.  "pkg info" will report the old WWW until the next PORTREVISION or upgrade, but I don't think it's worth triggering package builds just for that.
Comment 19 Anton Saietskii 2024-07-15 00:12:25 UTC
(In reply to Jason W. Bacon from comment #18)


According to section 5.2.3.1 of Porter's Handbook [0], 'PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way.'

As WWW is a part of package, I believe bump is required here.

[0]: https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-portrevision
Comment 20 Jason W. Bacon freebsd_committer freebsd_triage 2024-07-15 12:54:07 UTC
It does strictly say that, but later contradicts it with:

"Trivial patches to the distfile such as correction of typos, which are not important enough that users of the package have to go to the trouble of upgrading."

Even trivial changes in the distfile will result in an altered package, but in some cases it's not worth building a new package, since there are no functional changes to the software.

In my judgment, a change to WWW is basically the same.  It won't cause any harm if "pkg info" leads someone to the old WWW until the next incidental update.  It just means a few more mouse clicks to find the info they're after.