Bug 253321 - [patch] dev/usb/input/wsp: Add sysctl tunable for Z-Axis inversion
Summary: [patch] dev/usb/input/wsp: Add sysctl tunable for Z-Axis inversion
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: usb (show other bugs)
Version: 12.2-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-usb (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-07 14:54 UTC by James Wright
Modified: 2023-04-30 06:59 UTC (History)
4 users (show)

See Also:

Attachments
wsp.diff (2.59 KB, patch)
2021-02-07 14:54 UTC, James Wright 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Wright 2021-02-07 14:54:34 UTC 
Created attachment 222240 [details]
wsp.diff

Added a new sysctl to Wellspring  Touchpad (wsp) driver for controlling Z-Axis (2-finger vertical scroll) direction "hw.usb.wsp.z_invert". 

Updated documentation (also included missing description for z_factor tunable).
Comment 1 James Wright 2021-02-07 15:01:14 UTC 
Phabricator
https://reviews.freebsd.org/D28521
Comment 2 Tomasz "CeDeROM" CEDRO 2021-02-07 15:40:07 UTC 
Comment on attachment 222240 [details]
wsp.diff

Hello world :-)

Why not handle the "Narutal Scroll" via libinput??

/usr/local/share/X11/xorg.conf.d/40-libinput.conf:

Section "InputClass"
        Identifier "libinput touchpad catchall"
        MatchIsTouchpad "on"
        MatchDevicePath "/dev/input/event5"
        Option "NaturalScrolling" "on"
        Option "Tapping" "on"
        Option "ClickMethod" "clickfinger"
        Driver "libinput"
EndSection

Best regards :-)
Tomek
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-02-08 21:37:20 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=d8c6d4c7321d4c969216bda8f792b45ed00afd64

commit d8c6d4c7321d4c969216bda8f792b45ed00afd64
Author:     Vladimir Kondratyev <wulf@FreeBSD.org>
AuthorDate: 2021-02-08 21:26:42 +0000
Commit:     Vladimir Kondratyev <wulf@FreeBSD.org>
CommitDate: 2021-02-08 21:35:39 +0000

    wsp: Add sysctl tunable for Z-Axis inversion

    This adds a new sysctl to Wellspring Touchpad driver for controlling
    Z-Axis (2-finger vertical scroll) direction "hw.usb.wsp.z_invert".

    Submitted by:   James Wright <james.wright_AT_digital-chaos_DOT_com>
    Reviewed by:    wulf
    PR:             253321
    Differential revision:  https://reviews.freebsd.org/D28521

 share/man/man4/wsp.4    | 7 ++++++-
 sys/dev/usb/input/wsp.c | 7 ++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-04-30 06:59:06 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=00e2c99eb73aca5e46940c7993631314d485713a

commit 00e2c99eb73aca5e46940c7993631314d485713a
Author:     Vladimir Kondratyev <wulf@FreeBSD.org>
AuthorDate: 2021-02-08 21:26:42 +0000
Commit:     Hans Petter Selasky <hselasky@FreeBSD.org>
CommitDate: 2023-04-30 06:56:18 +0000

    wsp: Add sysctl tunable for Z-Axis inversion

    This adds a new sysctl to Wellspring Touchpad driver for controlling
    Z-Axis (2-finger vertical scroll) direction "hw.usb.wsp.z_invert".

    Submitted by:   James Wright <james.wright_AT_digital-chaos_DOT_com>
    Reviewed by:    wulf
    PR:             253321
    Differential revision:  https://reviews.freebsd.org/D28521

    (cherry picked from commit d8c6d4c7321d4c969216bda8f792b45ed00afd64)

 share/man/man4/wsp.4    | 7 ++++++-
 sys/dev/usb/input/wsp.c | 7 ++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)