Bug 253396 - security/tailscale: not starting correctly at boot time
Summary: security/tailscale: not starting correctly at boot time
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mikael Urankar
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2021-02-10 08:10 UTC by Mike Knell
Modified: 2021-02-13 10:42 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mikael)
koobs: merge-quarterly?

Attachments
Fix Tailscale startup issue (413 bytes, patch)
2021-02-10 10:49 UTC, Mike Knell 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Knell 2021-02-10 08:10:42 UTC 
Tailscale was not starting correctly at boot time - it was being started before networking was ready. Fixing the case on the NETWORKING dependency corrected this:

diff --git a/security/tailscale/files/tailscaled.in b/security/tailscale/files/tailscaled.in
index 716c4f7a3fa5..f2b418733d4f 100644
--- a/security/tailscale/files/tailscaled.in
+++ b/security/tailscale/files/tailscaled.in
@@ -3,7 +3,7 @@
 # $FreeBSD$
 #
 # PROVIDE: tailscaled
-# REQUIRE: networking
+# REQUIRE: NETWORKING
 # KEYWORD: shutdown
 #
 # Add the following lines to /etc/rc.conf.local or /etc/rc.conf

Cheers,
Mike
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-02-10 08:24:26 UTC 
Thank you for the report and patch Mike. Could you provide that as an attachment please (so it can be approved)
Comment 2 Mike Knell 2021-02-10 10:49:36 UTC 
Created attachment 222322 [details]
Fix Tailscale startup issue

Patch attached as requestd.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-02-11 16:13:06 UTC 
A commit references this bug:

Author: mikael
Date: Thu Feb 11 16:12:14 UTC 2021
New revision: 564959
URL: https://svnweb.freebsd.org/changeset/ports/564959

Log:
  security/tailscale: Update to 1.4.4

  While here fix rc script (pr 253396)

  Changes: https://github.com/tailscale/tailscale/releases/tag/v1.4.4

  PR:		253396
  Submitted by:	Mike Knell

Changes:
  head/security/tailscale/Makefile
  head/security/tailscale/distinfo
  head/security/tailscale/files/tailscaled.in