Bug 254054 - Extra space after loader_menu_title in new boot loader
Summary: Extra space after loader_menu_title in new boot loader
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Toomas Soome
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-06 03:41 UTC by Jose Luis Duran
Modified: 2021-03-10 20:24 UTC (History)
1 user (show)

See Also:

Attachments
Extra space after loader_menu_title (129.40 KB, image/png)
2021-03-06 03:41 UTC, Jose Luis Duran 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Luis Duran freebsd_committer freebsd_triage 2021-03-06 03:41:38 UTC 
Created attachment 223018 [details]
Extra space after loader_menu_title

There is an extra space after the loader_menu_title (Illumos does not have this extra space).

See attached image.
Comment 1 Toomas Soome freebsd_committer freebsd_triage 2021-03-06 09:40:22 UTC 
(In reply to Jose Luis Duran from comment #0)

hm, yes. This is bug with cursor draw, cursor off should restore the original image data.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-03-06 10:24:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=d708f23ebb06cfc9cf8f96f17a43eb63653b818a

commit d708f23ebb06cfc9cf8f96f17a43eb63653b818a
Author:     Toomas Soome <tsoome@FreeBSD.org>
AuthorDate: 2021-03-06 10:19:43 +0000
Commit:     Toomas Soome <tsoome@FreeBSD.org>
CommitDate: 2021-03-06 10:23:54 +0000

    loader: cursor off should restore display content

    When drawing cursor, we should store original display
    content because there may be image data we would like to restore
    when the cursor is removed.

    PR:             254054
    Reported by:    Jose Luis Duran
    MFC after:      3 days

 stand/common/gfx_fb.c | 38 ++++++++++++++++++++++++++++++++++++++
 stand/common/gfx_fb.h |  2 ++
 2 files changed, 40 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-03-09 07:33:52 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=38fe00d43dccb3bf4d49c60ab808bc0502753b29

commit 38fe00d43dccb3bf4d49c60ab808bc0502753b29
Author:     Toomas Soome <tsoome@FreeBSD.org>
AuthorDate: 2021-03-06 10:19:43 +0000
Commit:     Toomas Soome <tsoome@FreeBSD.org>
CommitDate: 2021-03-09 07:32:17 +0000

    loader: cursor off should restore display content

    When drawing cursor, we should store original display
    content because there may be image data we would like to restore
    when the cursor is removed.

    PR:             254054
    Reported by:    Jose Luis Duran

    (cherry picked from commit d708f23ebb06cfc9cf8f96f17a43eb63653b818a)

 stand/common/gfx_fb.c | 38 ++++++++++++++++++++++++++++++++++++++
 stand/common/gfx_fb.h |  2 ++
 2 files changed, 40 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-03-09 14:32:06 UTC 
A commit in branch releng/13.0 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=1ceb3c6c3bdbd0feabe1e071cac1a464bba125b1

commit 1ceb3c6c3bdbd0feabe1e071cac1a464bba125b1
Author:     Toomas Soome <tsoome@FreeBSD.org>
AuthorDate: 2021-03-06 10:19:43 +0000
Commit:     Toomas Soome <tsoome@FreeBSD.org>
CommitDate: 2021-03-09 14:30:47 +0000

    loader: cursor off should restore display content

    When drawing cursor, we should store original display
    content because there may be image data we would like to restore
    when the cursor is removed.

    PR:             254054
    Reported by:    Jose Luis Duran
    Approved by:    re (gjb)

    (cherry picked from commit d708f23ebb06cfc9cf8f96f17a43eb63653b818a)

 stand/common/gfx_fb.c | 38 ++++++++++++++++++++++++++++++++++++++
 stand/common/gfx_fb.h |  2 ++
 2 files changed, 40 insertions(+)
Comment 5 Jose Luis Duran freebsd_committer freebsd_triage 2021-03-10 20:24:33 UTC 
Thank you!