Bug 254141 - [ktls] struct tls_so_enable undefined
Summary: [ktls] struct tls_so_enable undefined
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: Unspecified
Hardware: Any Any
: --- Affects Many People
Assignee: John Baldwin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-08 18:40 UTC by Alan Somers
Modified: 2021-03-15 22:51 UTC (History)
0 users

See Also:
jhb: mfc-stable13+
jhb: mfc-stable12-
jhb: mfc-stable11-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2021-03-08 18:40:06 UTC
Revision 351522 introduced ktls.  The tcp.4 man page (later ktls.4) describes a "struct tls_so_enable" used with setsockopt.  However, that struct is not defined anywhere.  Could this be a misspelling in the man page?
Comment 1 John Baldwin freebsd_committer freebsd_triage 2021-03-08 18:45:35 UTC
Yes, it's 'struct tls_enable' in <sys/ktls.h> that is used with the TCP socket options.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-03-08 18:49:50 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c5a365623f88999b524d94003187ef09fda55f67

commit c5a365623f88999b524d94003187ef09fda55f67
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2021-03-08 18:46:40 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2021-03-08 18:46:40 +0000

    Correct the name of the structure used for TCP socket options.

    The structure was renamed while refactoring Netflix's KTLS changes for
    upstreaming, but the original name remained in tcp.4 and was
    subsequently copied to ktls.4.

    PR:             254141
    Reported by:    asomers
    MFC after:      3 days

 share/man/man4/ktls.4 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-03-11 22:23:55 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=0fc5395122b4b50564f3dc9164830a0d1635b622

commit 0fc5395122b4b50564f3dc9164830a0d1635b622
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2021-03-08 18:46:40 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2021-03-11 19:17:56 +0000

    Correct the name of the structure used for TCP socket options.

    The structure was renamed while refactoring Netflix's KTLS changes for
    upstreaming, but the original name remained in tcp.4 and was
    subsequently copied to ktls.4.

    PR:             254141
    Reported by:    asomers

    (cherry picked from commit c5a365623f88999b524d94003187ef09fda55f67)

 share/man/man4/ktls.4 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-03-11 23:39:06 UTC
A commit in branch releng/13.0 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=3b9e12f66e0cfd0c7db0eda9f72770499a6408b8

commit 3b9e12f66e0cfd0c7db0eda9f72770499a6408b8
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2021-03-08 18:46:40 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2021-03-11 23:37:45 +0000

    Correct the name of the structure used for TCP socket options.

    The structure was renamed while refactoring Netflix's KTLS changes for
    upstreaming, but the original name remained in tcp.4 and was
    subsequently copied to ktls.4.

    PR:             254141
    Reported by:    asomers
    Approved by:    re (gjb)

    (cherry picked from commit c5a365623f88999b524d94003187ef09fda55f67)
    (cherry picked from commit 0fc5395122b4b50564f3dc9164830a0d1635b622)

 share/man/man4/ktls.4 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)