Bug 254435 - security/passivedns: Add JSON option (log output support)
Summary: security/passivedns: Add JSON option (log output support)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason Helfman
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-03-20 16:02 UTC by Shawn Michael
Modified: 2021-10-06 20:15 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (shadowbq)

Attachments
Patch to add JSON output support (402 bytes, patch)
2021-03-20 16:02 UTC, Shawn Michael 		no flags Details | Diff
Revised patch based on recommendations (548 bytes, patch)
2021-05-13 23:44 UTC, Shawn Michael 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Michael 2021-03-20 16:02:19 UTC 
Created attachment 223452 [details]
Patch to add JSON output support

This is a patch to enable the -j and -J flags in passivedns.  These flags allow for the output of JSON formatted logs.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-05-13 01:03:26 UTC 
Thanks for the report and patch. 

Review items:

 - Rename option name to JSON (via what dependency its provided is less important than the feature itself)
 - Rename option description to "Enable JSON log format support"
 - Add the option to OPTIONS_DEFAULT
Comment 2 Shawn Michael 2021-05-13 23:44:20 UTC 
Created attachment 224918 [details]
Revised patch based on recommendations

I've uploaded a new patch with the requested revisions

Option is renamed to: JSON
Description is changed to: Enable JSON log format support
Added: OPTIONS_DEFAULT = JSON
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2021-05-25 16:30:30 UTC 
Adding maintainer for feedback. Added PORTREVISION bump to this.

-jgh
Comment 4 Shawn Michael 2021-08-20 16:14:36 UTC 
(In reply to Jason Helfman from comment #3)
Since the maintainer seems to be MIA, is it possible to proceed without their comment/review?

Shawn
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-10-06 19:14:51 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f51671acbd7d33d22cd4d3a8176d34bad237edde

commit f51671acbd7d33d22cd4d3a8176d34bad237edde
Author:     Jason Helfman <jgh@FreeBSD.org>
AuthorDate: 2021-10-06 19:12:15 +0000
Commit:     Jason Helfman <jgh@FreeBSD.org>
CommitDate: 2021-10-06 19:13:53 +0000

    security/passivedns: add JSON option

    PR:     254435 (based on)
    Submitted by: freebsd@monkeyspunk.net
    Approved by: maintainer timeout

 security/passivedns/Makefile | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 6 Jason Helfman freebsd_committer freebsd_triage 2021-10-06 19:15:40 UTC 
Thanks for the report! This has been committed.

-jgh