Bug 254488 - net/tcptestsuite: update to latest version
Summary: net/tcptestsuite: update to latest version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: George V. Neville-Neil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-22 20:31 UTC by Michael Tuexen
Modified: 2021-03-22 22:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnn)

Attachments
Patch for update (1.13 KB, patch)
2021-03-22 20:31 UTC, Michael Tuexen 		no flags Details | Diff
Updated patch for update (3.65 KB, patch)
2021-03-22 21:47 UTC, Michael Tuexen 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Tuexen freebsd_committer freebsd_triage 2021-03-22 20:31:46 UTC 
Created attachment 223508 [details]
Patch for update

Update for the tests corresponding to latest changes in the TCP stack.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2021-03-22 21:34:20 UTC 
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%DATADIR%%/fast-open/client/client-handle-cookie-update-of-length-04.exfail
Error: Missing: %%DATADIR%%/fast-open/client/client-handle-cookie-update-of-length-06.exfail
Error: Missing: %%DATADIR%%/fast-open/client/client-handle-cookie-update-of-length-08.exfail
Error: Missing: %%DATADIR%%/fast-open/client/client-handle-cookie-update-of-length-10.exfail
Error: Missing: %%DATADIR%%/fast-open/client/client-handle-cookie-update-of-length-12.exfail
Error: Missing: %%DATADIR%%/fast-open/client/client-handle-cookie-update-of-length-14.exfail
Error: Missing: %%DATADIR%%/fast-open/client/client-handle-cookie-update-of-length-16.exfail
===> Error: Plist issues found.

Some test files are tested?
Comment 2 Michael Tuexen freebsd_committer freebsd_triage 2021-03-22 21:44:33 UTC 
(In reply to Li-Wen Hsu from comment #1)
I removed these files from the GitHub repo, because the tests pass. So I need to change pkg-plist?
Comment 3 Li-Wen Hsu freebsd_committer freebsd_triage 2021-03-22 21:47:42 UTC 
(In reply to Michael Tuexen from comment #2)
Yes. pkg-plist is the "package list" which lists the files will be installed to the system.
Comment 4 Michael Tuexen freebsd_committer freebsd_triage 2021-03-22 21:47:51 UTC 
Created attachment 223509 [details]
Updated patch for update
Comment 5 Michael Tuexen freebsd_committer freebsd_triage 2021-03-22 21:48:19 UTC 
(In reply to Li-Wen Hsu from comment #3)
OK. I updated the patch.
Comment 6 Li-Wen Hsu freebsd_committer freebsd_triage 2021-03-22 21:53:05 UTC 
(In reply to Michael Tuexen from comment #5)
tested fine for me.  I think you and gnn needs:

Approved by: lwhsu (ports)

(In reply to Li-Wen Hsu from comment #1)
I actually mean "Some test files are removed?", but it looks you got it. :-)
Comment 7 Michael Tuexen freebsd_committer freebsd_triage 2021-03-22 21:55:39 UTC 
(In reply to Li-Wen Hsu from comment #6)
I removed some files indicating that it is expected that some tests are failing, because they are not failing.

Should I leave the commit for gnn (who is the maintainer again) or should I go ahead with committing?

Best regards
Michael
Comment 8 Li-Wen Hsu freebsd_committer freebsd_triage 2021-03-22 21:58:49 UTC 
(In reply to Michael Tuexen from comment #7)
It requires maintainer's explicitly approve to update a port. Since you're working closely. I suggest you can ask gnn to allow you to do the update implicitly. Then all you need is a review for a ports committer. (Then the next think I will encourage you is to earn a ports bit :-)
Comment 9 George V. Neville-Neil freebsd_committer freebsd_triage 2021-03-22 22:32:07 UTC 
I'm happy with this patch and to have Michael commit it.

Thanks!
Comment 10 Michael Tuexen freebsd_committer freebsd_triage 2021-03-22 22:41:13 UTC 
(In reply to George V. Neville-Neil from comment #9)
Done, thanks for the quick approval.
Comment 11 commit-hook freebsd_committer freebsd_triage 2021-03-22 22:41:14 UTC 
A commit references this bug:

Author: tuexen
Date: Mon Mar 22 22:40:37 UTC 2021
New revision: 568990
URL: https://svnweb.freebsd.org/changeset/ports/568990

Log:
  net/tcptestsuite: Update to 20210322

  PR:		254488
  Approved by:	gnn (maintainer), lwhsu (ports)

Changes:
  head/net/tcptestsuite/Makefile
  head/net/tcptestsuite/distinfo
  head/net/tcptestsuite/pkg-plist