Bug 254526 - [PATCH] mail/spamassassin Update to 3.4.5 fixing CVE-2020-1946
Summary: [PATCH] mail/spamassassin Update to 3.4.5 fixing CVE-2020-1946
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Cy Schubert
URL: https://cve.mitre.org/cgi-bin/cvename...
Keywords: security
Depends on:
Blocks:
 
Reported: 2021-03-24 18:05 UTC by Cy Schubert
Modified: 2021-04-14 07:36 UTC (History)
5 users (show)

See Also:
zeising: maintainer-feedback+
cy: merge-quarterly+


Attachments
Patch (1.38 KB, patch)
2021-03-24 18:07 UTC, Cy Schubert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cy Schubert freebsd_committer freebsd_triage 2021-03-24 18:05:49 UTC
This patch updates mail/spamassassin to 3.4.5 fixing CVE-2020-1946. Email from apache.org below:

Subject: [CVE-2020-1946] Apache SpamAssassin malicious rule configuration
 (.cf) files can be configured to run system commands
From: Sidney Markowitz <sidney@apache.org>
Date: Thu, 25 Mar 2021 05:08:23 +1300 (Wed 09:08 PDT)
To: Sidney Markowitz <sidney@apache.org>

(Unknown charset: <utf-8>)

Apache SpamAssassin 3.4.5 was recently released [1], and fixes an issue of security note where malicious rule configuration (.cf) files can be configured to run system commands.

In Apache SpamAssassin before 3.4.5, exploits can be injected in a number of scenarios. In addition to upgrading to SA 3.4.5, users should only use update channels or 3rd party .cf files from trusted places.

Apache SpamAssassin would like to thank Damian Lukowski at credativ for ethically reporting this issue.

This issue has been assigned CVE id CVE-2020-1946 [2]

To contact the Apache SpamAssassin security team, please e-mail
security at spamassassin.apache.org. For more information about Apache
SpamAssassin, visit the https://spamassassin.apache.org/ web site.

Apache SpamAssassin Security Team

[1]: https://s.apache.org/ng9u9

[2]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2020-1946

-- 
Sidney Markowitz
Chair, Apache SpamAssassin PMC
sidney@apache.org
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2021-03-24 18:06:35 UTC
I'm able to commit if maintainer and ports-secteam agree.
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2021-03-24 18:07:42 UTC
Created attachment 223549 [details]
Patch

Oops, forgot to attach the patch.
Comment 3 Niclas Zeising freebsd_committer freebsd_triage 2021-03-24 19:30:02 UTC
Approved.

Will you write a vuXML entry as well?
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2021-03-24 19:39:19 UTC
Sure I can do that too.
Comment 5 Cy Schubert freebsd_committer freebsd_triage 2021-03-24 20:02:45 UTC
Reassigning to me for commit.
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-03-24 20:03:06 UTC
A commit references this bug:

Author: cy
Date: Wed Mar 24 20:02:53 UTC 2021
New revision: 569156
URL: https://svnweb.freebsd.org/changeset/ports/569156

Log:
  mail/spamassassin: Update 3.4.4 --> 3.4.5, fixing CVE-2020-1946

  According to https://s.apache.org/ng9u9, 3.4.5 fixes CVE-2020-1946.
  The announce text:

  Apache SpamAssassin 3.4.5 was recently released [1], and fixes an issue
  of security note where malicious rule configuration (.cf) files can be
  configured to run system commands.

  In Apache SpamAssassin before 3.4.5, exploits can be injected in a number
  of scenarios. In addition to upgrading to SA 3.4.5, users should only use
  update channels or 3rd party .cf files from trusted places.

  Apache SpamAssassin would like to thank Damian Lukowski at credativ for
  ethically reporting this issue.

  This issue has been assigned CVE id CVE-2020-1946 [2]

  To contact the Apache SpamAssassin security team, please e-mail
  security at spamassassin.apache.org. For more information about Apache
  SpamAssassin, visit the https://spamassassin.apache.org/ web site.

  Apache SpamAssassin Security Team

  [1]: https://s.apache.org/ng9u9

  [2]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2020-1946

  PR:		254526
  Submitted by:	cy
  Reported by:	cy
  Approved by:	maintainer (zeising)
  MFH:		2021Q1
  Security:	https://s.apache.org/ng9u9
  		https://cve.mitre.org/cgi-bin/cvename.cgi?name=2020-1946

Changes:
  head/mail/spamassassin/Makefile
  head/mail/spamassassin/distinfo
  head/mail/spamassassin/pkg-plist
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-03-24 20:03:07 UTC
A commit references this bug:

Author: cy
Date: Wed Mar 24 20:02:59 UTC 2021
New revision: 569157
URL: https://svnweb.freebsd.org/changeset/ports/569157

Log:
  security/vuxml: Document spamassassin CVE-2020-1946

  PR:		254526
  Security:	https://s.apache.org/ng9u9
  		https://cve.mitre.org/cgi-bin/cvename.cgi?name=2020-1946

Changes:
  head/security/vuxml/vuln.xml
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-03-24 20:06:08 UTC
A commit references this bug:

Author: cy
Date: Wed Mar 24 20:05:32 UTC 2021
New revision: 569158
URL: https://svnweb.freebsd.org/changeset/ports/569158

Log:
  MFH: r569156

  mail/spamassassin: Update 3.4.4 --> 3.4.5, fixing CVE-2020-1946

  According to https://s.apache.org/ng9u9, 3.4.5 fixes CVE-2020-1946.
  The announce text:

  Apache SpamAssassin 3.4.5 was recently released [1], and fixes an issue
  of security note where malicious rule configuration (.cf) files can be
  configured to run system commands.

  In Apache SpamAssassin before 3.4.5, exploits can be injected in a number
  of scenarios. In addition to upgrading to SA 3.4.5, users should only use
  update channels or 3rd party .cf files from trusted places.

  Apache SpamAssassin would like to thank Damian Lukowski at credativ for
  ethically reporting this issue.

  This issue has been assigned CVE id CVE-2020-1946 [2]

  To contact the Apache SpamAssassin security team, please e-mail
  security at spamassassin.apache.org. For more information about Apache
  SpamAssassin, visit the https://spamassassin.apache.org/ web site.

  Apache SpamAssassin Security Team

  [1]: https://s.apache.org/ng9u9

  [2]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2020-1946

  PR:		254526
  Submitted by:	cy
  Reported by:	cy
  Approved by:	maintainer (zeising)
  Security:	https://s.apache.org/ng9u9
  		https://cve.mitre.org/cgi-bin/cvename.cgi?name=2020-1946

Changes:
_U  branches/2021Q1/
  branches/2021Q1/mail/spamassassin/Makefile
  branches/2021Q1/mail/spamassassin/distinfo
  branches/2021Q1/mail/spamassassin/pkg-plist
Comment 9 Cy Schubert freebsd_committer freebsd_triage 2021-03-24 20:06:33 UTC
Fixed.
Comment 10 John R 2021-03-25 12:15:22 UTC
Builds fine but fails to start...

Stopping spamd.
Waiting for PIDS: 44869.
Starting spamd.
child process [63928] exited or timed out without signaling production of a PID file: exit 255 at /usr/local/bin/spamd line 3034.
/usr/local/etc/rc.d/sa-spamd: WARNING: failed to start spamd
Comment 11 Cy Schubert freebsd_committer freebsd_triage 2021-03-25 15:52:29 UTC
Yes, it will fail to start until you run sa-update to download a new database. Do that first, then start it.

Also, install mail/sa-utils to run sa-update daily through periodic(8). It's best practice to maintain an updated database.
Comment 12 John R 2021-03-25 16:54:23 UTC
Thanks for that, works like a charm now.