Bug 254543 - textproc/expat2: Update to 2.3.0
Summary: textproc/expat2: Update to 2.3.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-25 12:04 UTC by Daniel Engberg
Modified: 2023-12-30 20:52 UTC (History)
3 users (show)

See Also:
tcberner: maintainer-feedback+
antoine: exp-run+

Attachments
Patch for expat2 (2.15 KB, patch)
2021-03-25 12:04 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-03-25 12:04:20 UTC 
Created attachment 223565 [details]
Patch for expat2

Update expat to 2.3.0
Make static library optional and not enabled by default

Compile and tested on FreeBSD 13.0-RC1 (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-03-25 12:04:47 UTC 
We should do a exp-run on this to avoid unnecessary breakage
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2021-03-26 16:55:07 UTC 
Moin moin 

Thanks for the patch -- IMO the STATIC option and thereby the library could be dropped completely.


mfg Toibas
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2021-03-26 16:55:40 UTC 
Moin moin 


desktop@ would like to ask for an exp-run of the attached patch.


mfg Tobias
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2021-03-31 15:03:11 UTC 
Exp-run looks fine
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-04-14 17:40:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d06d7188f31e5df646b41f7a8abf9a9cfd74578b

commit d06d7188f31e5df646b41f7a8abf9a9cfd74578b
Author:     Daniel Engberg <daniel.engberg.lists@pyret.net>
AuthorDate: 2021-04-14 17:36:21 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-04-14 17:38:18 +0000

    textproc/expat: update to 2.3.0

    - Move static libraries behind an option STATIC. This will likely
      be dropped completely in the next update.

    PR:             254543
    Exp-run by:     antoine

 textproc/expat2/Makefile  | 11 +++++++----
 textproc/expat2/distinfo  |  6 +++---
 textproc/expat2/pkg-plist |  8 ++++++--
 3 files changed, 16 insertions(+), 9 deletions(-)
Comment 6 Tobias C. Berner freebsd_committer freebsd_triage 2021-04-14 17:43:00 UTC 
Committed, thanks for the patch and the exp-run.


mfg Tobias
Comment 7 Slawomir Wojciech Wojtczak 2023-12-30 00:23:12 UTC 
Is there some specific reason WHY the STATIC LIBRARY option has been dropped?

Like a security hole ... or something else?

Thanks.
Comment 8 Daniel Engberg freebsd_committer freebsd_triage 2023-12-30 10:06:29 UTC 
It's optional, just use the STATIC option if you need it.
Comment 9 Slawomir Wojciech Wojtczak 2023-12-30 20:38:00 UTC 
(In reply to Daniel Engberg from comment #8)

Yes, I have already done that, I have built 'textproc/expat2' with STATIC enabled to build 'sysutils/mstflint' as STATIC port.

That is the reason I ask because WHY the default switched to disable STATIC.

Regards,
vermaden
Comment 10 Daniel Engberg freebsd_committer freebsd_triage 2023-12-30 20:46:40 UTC 
The short answer is because the tree utilizes shared libraries by default and builds fine without it, currently it's not possible to satisfy all possible options in consumers.
Comment 11 Slawomir Wojciech Wojtczak 2023-12-30 20:52:16 UTC 
(In reply to Daniel Engberg from comment #10)

Sure, just checking.

Maybe its a potential candidate for 'flavor' with STATIC enabled?