Bug 254582 - devel/xdg-utils: optionalize X11-related dependencies
Summary: devel/xdg-utils: optionalize X11-related dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-03-26 16:31 UTC by Ghost
Modified: 2021-04-14 18:02 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (desktop)

Attachments
patch (761 bytes, patch)
2021-03-26 16:31 UTC, Ghost 		tcberner: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ghost 2021-03-26 16:31:25 UTC 
Created attachment 223612 [details]
patch

Runtime dependencies x11/xprop and x11/xset do not work on systems with no X11-related packages for obvious reasons.

Optionalize them to avoid building/installing libX11 and related packages.

Initial version seen / Inspired by: DankBSD ports by Greg V
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2021-03-26 16:36:23 UTC 
Comment on attachment 223612 [details]
patch

LGTM, thanks


mfg Tobias
Comment 2 Ghost 2021-04-14 17:49:32 UTC 
May I ask someone commit this? >2 weeks passed after maintainer approval.
No functional change for vanilla builds.

I'm not updating to git-format-patch due to the low amount of change.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-04-14 17:59:09 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=07a887563d712b4055582f4b3bbf24d9edada998

commit 07a887563d712b4055582f4b3bbf24d9edada998
Author:     Evgeniy Khramtsov <evgeniy@khramtsov.org>
AuthorDate: 2021-04-14 17:55:26 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-04-14 17:58:21 +0000

    devel/xdg-utils: optionalize X11-related dependencies

    PR:             254582

 devel/xdg-utils/Makefile | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2021-04-14 18:02:39 UTC 
Committed, thanks :)