Bug 254664 - Garmin USB Quirk / Please add new models
Summary: Garmin USB Quirk / Please add new models
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: usb (show other bugs)
Version: 12.2-STABLE
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Hans Petter Selasky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-30 18:21 UTC by Harry Matthiesen Jensen
Modified: 2021-05-10 14:33 UTC (History)
1 user (show)

See Also:

Attachments
The usb_quirk.c patch file (801 bytes, patch)
2021-03-30 20:22 UTC, Harry Matthiesen Jensen 		no flags Details | Diff
The usbdevs patch (505 bytes, patch)
2021-03-30 20:24 UTC, Harry Matthiesen Jensen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Harry Matthiesen Jensen 2021-03-30 18:21:50 UTC 
Following Garmin GPS will only be available if listed in the /boot/loader.conf:
# Garmin Instinct Solar
hw.usb.quirk.0="0x091e 0x0d8a 0x0000 0xffff UQ_MSC_NO_INQUIRY"
# Dakota 20
hw.usb.quirk.1="0x091e 0x23c0 0x0000 0xffff UQ_MSC_NO_INQUIRY"
# Edge Touring+
hw.usb.quirk.2="0x091e 0x26c8 0x0000 0xffff UQ_MSC_NO_INQUIRY"

Will it be possible to have the models numbers added to head/sys/dev/usb/usbdevs and the quirks added to the head/sys/dev/usb/quirk/usb_quirk.c ?

See also solution in bug report 210544

Brgds. Harry MJ
Comment 1 Hans Petter Selasky freebsd_committer freebsd_triage 2021-03-30 19:03:06 UTC 
Yes, that's possible. Can you make a patch for that?

--HPS
Comment 2 Harry Matthiesen Jensen 2021-03-30 19:14:46 UTC 
Yes, I will give it a try to create a patch file.

--
Brgds. Harry MJ
Comment 3 Harry Matthiesen Jensen 2021-03-30 20:22:46 UTC 
Created attachment 223715 [details]
The usb_quirk.c patch file

The usb_quirk.c patch file, if wrong format, please state the correct method for diff
Comment 4 Harry Matthiesen Jensen 2021-03-30 20:24:21 UTC 
Created attachment 223716 [details]
The usbdevs patch

The usbdevs patch file, if wrong format, please state the correct method for diff
Comment 5 Hans Petter Selasky freebsd_committer freebsd_triage 2021-03-31 12:25:34 UTC 
Patches look good.

--HPS
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-04-22 10:37:36 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=28af0c4814f5fb8ce047d4ac0bbf26997ac5cc8f

commit 28af0c4814f5fb8ce047d4ac0bbf26997ac5cc8f
Author:     Hans Petter Selasky <hselasky@FreeBSD.org>
AuthorDate: 2021-04-22 10:31:33 +0000
Commit:     Hans Petter Selasky <hselasky@FreeBSD.org>
CommitDate: 2021-04-22 10:35:07 +0000

    Add more USB quirks for Garmin devices.
    Sort the Garmin products while at it.

    PR:             254664
    MFC after:      1 week
    Sponsored by:   Mellanox Technologies // NVIDIA Networking

 sys/dev/usb/quirk/usb_quirk.c | 2 ++
 sys/dev/usb/usbdevs           | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-05-10 14:33:07 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a122a5ebdee28f7bbd50d21558a7328bf730c195

commit a122a5ebdee28f7bbd50d21558a7328bf730c195
Author:     Hans Petter Selasky <hselasky@FreeBSD.org>
AuthorDate: 2021-04-22 10:31:33 +0000
Commit:     Hans Petter Selasky <hselasky@FreeBSD.org>
CommitDate: 2021-05-10 14:11:19 +0000

    Add more USB quirks for Garmin devices.
    Sort the Garmin products while at it.

    PR:             254664
    Sponsored by:   Mellanox Technologies // NVIDIA Networking

    (cherry picked from commit 28af0c4814f5fb8ce047d4ac0bbf26997ac5cc8f)

 sys/dev/usb/quirk/usb_quirk.c | 2 ++
 sys/dev/usb/usbdevs           | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)