Bug 254672 - netstat -s --libxo json duplicate "shutdown-timer" field
Summary: netstat -s --libxo json duplicate "shutdown-timer" field
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 12.1-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: Warner Losh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-31 08:09 UTC by j.vandeville
Modified: 2025-02-13 04:48 UTC (History)
1 user (show)

See Also:
linimon: mfc-stable14?
linimon: mfc-stable13?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description j.vandeville 2021-03-31 08:09:43 UTC
In the "timeouts" section of sctp, the field "shutdown-timer" is duplicate

"timeouts":{
            "iterator":0,
            "t3-data":0,
            "window-probe":0,
            "init-timer":0,
            "sack-timer":0,
            "shutdown-timer":0,
            "heartbeat-timer":0,
            "cookie-timer":0,
            "endpoint-changed-cookie":0,
            "pmtu-timer":0,
            "shutdown-timer":0,
            "shutdown-guard-timer":0,
            "stream-reset-timer":0,
            "early-fast-retransmission-timer":0,
            "asconf-timer":0,
            "auto-close-timer":0,
            "asoc-free-timer":0,
            "input-free-timer":0
         },

According to "netstat -s" output, the second "shutdown-timer" should be "shutdown-ack-timer"
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-09-20 15:58:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=674b96f58b9c7daabb53ba3180afe4fc26354e27

commit 674b96f58b9c7daabb53ba3180afe4fc26354e27
Author:     Bram <bram@cbbg.nl>
AuthorDate: 2024-07-23 09:05:13 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-09-20 15:06:50 +0000

    netstat: Add missing "shutdown-ack-timer" key to libxo output

    The key "shutdown-timer" was present twice in the libxo output. The second
    occurence of "shutdown-time" has been renamed to "shutdown-ack-timer".

    PR: 254672
    Reviewed by: imp, zlei
    Pull Request: https://github.com/freebsd/freebsd-src/pull/1331

 usr.bin/netstat/if.c   | 4 ++--
 usr.bin/netstat/sctp.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2025-02-13 04:48:57 UTC
^Triage: assign to committer.  Set flags for possible MFC (just close this
if not desireable).