Bug 255215 - SVNWEB no longer updated for ports
Summary: SVNWEB no longer updated for ports
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Website (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-19 09:53 UTC by Stefan Eßer
Modified: 2023-08-27 11:34 UTC (History)
3 users (show)

See Also:

Attachments
Patch to fix ports.cgi (521 bytes, patch)
2021-04-19 10:00 UTC, Stefan Eßer 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Eßer freebsd_committer freebsd_triage 2021-04-19 09:53:50 UTC 
After the switch to GIT, the ports SVN repository is in a frozen state.

This causes accesses to https://svnweb.freebsd.org/ports/head/ to return 
stale information.

But the real issue IMHO is that the "FreeBSD Ports Search" page on the
web server does return 404 errors for ports that have been created in
GIT and did not exist in SVN.

Reproduce by e.g.:

https://www.freebsd.org/cgi/ports.cgi?query=yaze-ag&stype=name

and then click on any of the links (e.g. "Description").

This returns an error page with status 404:

https://svnweb.freebsd.org/ports/head/emulators/yaze-ag

The correct, new URL is:

https://cgit.freebsd.org/ports/tree/emulators/yaze-ag

FIX:

Somebody needs to apply the following changes to ports.cgi:

Hostname: replace "svnweb" with "cgit"
Path:     replace "ports/head" with "ports/tree"
Comment 1 Stefan Eßer freebsd_committer freebsd_triage 2021-04-19 10:00:53 UTC 
Created attachment 224246 [details]
Patch to fix ports.cgi

Fix path to port information queried with the "FreeBSD Ports Search" page.
Comment 2 Stefan Eßer freebsd_committer freebsd_triage 2021-04-19 10:07:20 UTC 
A review has been created for the suggested fix: D29829
Comment 3 Li-Wen Hsu freebsd_committer freebsd_triage 2021-04-19 13:55:07 UTC 
This reminds me I need to figure out the cgi deployment after the doc migrating to asciidoc. I'll try to squeeze some time on this...
Comment 4 Stefan Eßer freebsd_committer freebsd_triage 2021-04-19 21:45:10 UTC 
The path suggested in the initial description of the issue was wrong, since it does not return the plain file data as did the svnweb URL.

The correct URL prefix is:

https://cgit.FreeBSD.org/ports/plain

e.g. https://cgit.FreeBSD.org/ports/plain/emulators/yaze-ag/pkg-descr

See the patch attached to https://reviews.freebsd.org/D29829
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-04-29 18:49:47 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=582cf4227c03af60806e9c437703f3fe0b0ea374

commit 582cf4227c03af60806e9c437703f3fe0b0ea374
Author:     Stefan EÃer <se@FreeBSD.org>
AuthorDate: 2021-04-29 18:01:32 +0000
Commit:     Stefan EÃer <se@FreeBSD.org>
CommitDate: 2021-04-29 18:01:32 +0000

    content/en/cgi: Fix paths in cgi-style.pl, man.cgi, and ports.cgi

    Adjust paths to point at cgit.freebsd.org instead of svnweb.

    An attempt has been made to provide the same kind of information as
    before, but the layout and information displayed by cgit is different
    from that of svnweb.

    Reviewed by:    wosch
    PR:             255215
    Differential Revision:  https://reviews.freebsd.org/D29829

 website/content/en/cgi/cgi-style.pl |  2 +-
 website/content/en/cgi/man.cgi      |  2 +-
 website/content/en/cgi/ports.cgi    | 16 +++++++++-------
 3 files changed, 11 insertions(+), 9 deletions(-)
Comment 6 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2023-08-27 11:34:49 UTC 
Fixed. Thanks for the report.