Created attachment 224401 [details] Patch Updated to 1897. Added 'Created by:', without this portlint shows many errors. Portlint: looks fine. Changelog: https://github.com/cglogic/gn/compare/v1823...v1897
Hi Oleh, Thanks for the update. As the maintainer of the port, please also set the 'maintainer-approval' flag to '+' (Attachments -> Details -> Maintainer-approval). I expect portlint to be updated in the next time, so adding 'Created by' as a 'workaround is not really necessary ;)
(In reply to Rainer Hurling from comment #1) Some of my ports have 'Created by:', some not, should I remove it from the diff?
(In reply to Oleh Hushchenkov from comment #2) Actually, it has not been common practice to enter 'Created by' for new ports for a few years now. For existing ports the entry is 'tolerated'. Therefore some maintainers remove their entry, others do not. Personally, I have no problem with the entry being subsequently made in custom ports. So let's see, what happens ;)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0eaae11a7b886f626b8a491e644cd47ddf5403cb commit 0eaae11a7b886f626b8a491e644cd47ddf5403cb Author: Rainer Hurling <rhurlin@FreeBSD.org> AuthorDate: 2021-04-24 18:56:58 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2021-04-24 18:56:58 +0000 devel/gn: Update to 1897 Changelog: https://github.com/cglogic/gn/compare/v1823...v1897 PR: 255365 Submitted by: Oleh Hushchenkov <o.hushchenkov@gmail.com> (maintainer) devel/gn/Makefile | 7 ++++--- devel/gn/distinfo | 6 +++--- devel/gn/files/patch-build_gen.py | 4 ++-- devel/gn/files/patch-src_gn_args.cc | 4 ++-- 4 files changed, 11 insertions(+), 10 deletions(-)
Committed, thanks :)