Bug 255431 - Wrong definition in sysutils/uefi-edk2-bhyve
Summary: Wrong definition in sysutils/uefi-edk2-bhyve
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Rebecca Cran
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-26 19:34 UTC by Dancho Penev
Modified: 2022-04-05 17:31 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (bcran)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dancho Penev 2021-04-26 19:34:03 UTC 
--- a/sysutils/uefi-edk2-bhyve/Makefile
+++ b/sysutils/uefi-edk2-bhyve/Makefile
@@ -55,7 +55,7 @@ HTTP_BOOT_DESC=       Build with HTTP(S) boot support

 DEBUG_VARS=    PLAT_TARGET=DEBUG
 DEBUG_VARS_OFF=        PLAT_TARGET=RELEASE
-HTTP_BOOT_VARS=        PLAT_ARGS+=-DHTTP_BOOT_ENABLE=TRUE
+HTTP_BOOT_VARS=        PLAT_ARGS+=-DNETWORK_HTTP_BOOT_ENABLE=TRUE

 PLAT_ARGS+=    -DDEBUG_ON_SERIAL_PORT=TRUE
Comment 1 Rebecca Cran freebsd_committer freebsd_triage 2021-05-02 00:08:53 UTC 
Thanks! I've fixed it locally and will commit it next week.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-05-02 17:10:24 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4cec3f9086f382a492522c85b1c5b702e545c00f

commit 4cec3f9086f382a492522c85b1c5b702e545c00f
Author:     Rebecca Cran <bcran@FreeBSD.org>
AuthorDate: 2021-05-02 17:08:36 +0000
Commit:     Rebecca Cran <bcran@FreeBSD.org>
CommitDate: 2021-05-02 17:09:21 +0000

    sysutils/uefi-edk2-bhyve: Update to edk2-stable202002 tag

    This fixes PR 255431 and makes HTTP(S) boot support work.

    PR:     255431
    Approved by:    manu
    Reviewed by:    manu,imp
    Differential Revision:  https://reviews.freebsd.org/D30075

 sysutils/uefi-edk2-bhyve/Makefile | 6 +++---
 sysutils/uefi-edk2-bhyve/distinfo | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 3 Volodymyr Kostyrko 2022-04-04 08:44:57 UTC 
Probably should be closed? Thank you.