Bug 256048 - emulators/virtualbox-ose-additions CONFLICTS_INSTALL emulators/virtualbox-ose-additions-legacy
Summary: emulators/virtualbox-ose-additions CONFLICTS_INSTALL emulators/virtualbox-ose...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Virtualbox Team (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-21 06:33 UTC by Graham Perrin
Modified: 2021-08-30 07:20 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+


Attachments
Screenshot: installing legacy where previously there was non-legacy (41.02 KB, image/png)
2021-05-21 06:36 UTC, Graham Perrin
no flags Details
Screenshot: installing non-legacy where previously there was legacy (41.55 KB, image/png)
2021-05-21 06:37 UTC, Graham Perrin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2021-05-21 06:33:47 UTC
Please, is something missing here? 

% grep CONFLICT /usr/ports/emulators/virtualbox-ose-additions/Makefile
CONFLICTS_INSTALL=      virtualbox-ose-[0-9]* \
CONFLICTS_INSTALL+=     virtualbox-ose-additions-nox11-[0-9]*
CONFLICTS_INSTALL+=     virtualbox-ose-additions-[0-9]*
% grep CONFLICT /usr/ports/emulators/virtualbox-ose-additions-legacy/Makefile
CONFLICTS_INSTALL=      virtualbox-ose-[0-9]* \
CONFLICTS_INSTALL+=     virtualbox-ose-additions-nox11-[0-9]*
CONFLICTS_INSTALL+=     virtualbox-ose-additions-[0-9]*
% date ; uname -KrU
Fri 21 May 2021 07:30:20 BST
14.0-CURRENT 1400013 1400013
% grep url /etc/pkg/FreeBSD.conf
  url: "pkg+http://pkg.FreeBSD.org/${ABI}/latest",
%
Comment 1 Graham Perrin freebsd_committer freebsd_triage 2021-05-21 06:36:34 UTC
Created attachment 225144 [details]
Screenshot: installing legacy where previously there was non-legacy
Comment 2 Graham Perrin freebsd_committer freebsd_triage 2021-05-21 06:37:13 UTC
Created attachment 225145 [details]
Screenshot: installing non-legacy where previously there was legacy
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2021-05-21 07:03:01 UTC
<https://cgit.freebsd.org/ports/tree/emulators/virtualbox-ose-additions/Makefile?id=42d8425b62bb66d04dd01c96d516c11451fd86dd#n43> should there be an additional line? 

			virtualbox-ose-additions-legacy-[0-9]* \

Originally, a few days ago (before taking screenshots) I was puzzled by 
<https://www.freshports.org/emulators/virtualbox-ose-additions/#conflicts>
_not_ listing: 

    virtualbox-ose-additions-legacy-[0-9]*

----

(In reply to comment #0)

Sorry, my grep there was careless. Instead: 

% grep -A 6 "CONFLICTS_INSTALL=" /usr/ports/emulators/virtualbox-ose-additions/Makefile
CONFLICTS_INSTALL=      virtualbox-ose-[0-9]* \
                        virtualbox-ose-additions-devel-[0-9]* \
                        virtualbox-ose-devel-[0-9]* \
                        virtualbox-ose-legacy-[0-9]* \
                        virtualbox-ose-lite-[0-9]* \
                        virtualbox-ose-nox11-[0-9]*

% grep -C 1 "CONFLICTS_INSTALL+=" /usr/ports/emulators/virtualbox-ose-additions/Makefile
.if ${SLAVE_PORT} == no
CONFLICTS_INSTALL+=     virtualbox-ose-additions-nox11-[0-9]*
.else
CONFLICTS_INSTALL+=     virtualbox-ose-additions-[0-9]*
.endif
%
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2021-05-21 07:52:36 UTC
I'm not getting the point. Thise two ports are conflicting and the behaviour is expected. Where you expecting a different behaviour?

Anyway looking at the Makefile yes there are improvements that can be made to the conflicts lines. I'll take a look.

By the way grepping Makefile variables like that is giving you partial results.

The main conflicts line has more content (the trailing backslash is an indication more is following), from virtualbox-ose-additions:

CONFLICTS_INSTALL=      virtualbox-ose-[0-9]* \
                        virtualbox-ose-additions-devel-[0-9]* \
                        virtualbox-ose-devel-[0-9]* \
                        virtualbox-ose-legacy-[0-9]* \
                        virtualbox-ose-lite-[0-9]* \
                        virtualbox-ose-nox11-[0-9]*


Some of these lines have been there for a while and are retained just in case. No sure if also cleaning up the no more relevant ones (no -devel or -lite port for a while) is required.
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2021-05-21 07:53:31 UTC
(In reply to Graham Perrin from comment #3)

Oops, replied before reading this. Yes, something is missing and there is a duplicated line at least.
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-05-22 15:44:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8b0a535c5a3331be21612f3322247998bf87b7e9

commit 8b0a535c5a3331be21612f3322247998bf87b7e9
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-05-22 15:42:28 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-05-22 15:42:28 +0000

    emulators/virtualbox-ose-additions(-legacy): fix conflicts

    - Add missing conflicts lines to emulators/virtualbox-ose-additions
      ports
    - Remove duplicate entry in emulators/virtualbox-ose-additions-legacy
      CONFLICTS_INSTALL

    PR:             256048

 emulators/virtualbox-ose-additions-legacy/Makefile | 2 +-
 emulators/virtualbox-ose-additions/Makefile        | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Comment 7 Guido Falsi freebsd_committer freebsd_triage 2021-05-22 15:44:56 UTC
Added missing conflict lines.

Thanks for reporting.
Comment 8 Graham Perrin freebsd_committer freebsd_triage 2021-05-22 16:13:09 UTC
Thanks, and 

(In reply to Guido Falsi from comment #5)

> Oops, …

– no problem. 

My mind typically goes blank when I see a Bugzilla representation of a mid-air collision :-)