At Thu, 8 Mar 2001 14:04:44 +0100 (CET), freebsd-admin@blender.nl wrote: > -.if !defined(NOPORTDOCS) > ${MKDIR} ${PREFIX}/share/doc/blender > ${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/doc/blender > ${INSTALL_DATA} ${WRKSRC}/copyright.txt ${PREFIX}/share/doc/blender > -.endif Why you remove NOPORTDOCS? If you want install docs for every user, pkg-plist need to be fixed too.
FUJISHIMA Satsuki wrote: > At Thu, 8 Mar 2001 14:04:44 +0100 (CET), > freebsd-admin@blender.nl wrote: > > -.if !defined(NOPORTDOCS) > > ${MKDIR} ${PREFIX}/share/doc/blender > > ${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/doc/blender > > ${INSTALL_DATA} ${WRKSRC}/copyright.txt ${PREFIX}/share/doc/blender > > -.endif > > Why you remove NOPORTDOCS? If you want install docs for every user, I must, because of the required copyright.txt file. > pkg-plist need to be fixed too. Oh ? sorry. Please remove %%PORTDOCS%% there, I hope that that's all. regards, Hans Lambermont -- ir Hans Lambermont hans@blender.nl +31(0)40 2501229 Not A Number, Meerenakkerplein 16, 5652 BJ Eindhoven, the Netherlands Blender, free 3D software for the new millennium http://www.blender.nl
At Thu, 8 Mar 2001 18:00:59 +0100, Hans Lambermont wrote: > > Why you remove NOPORTDOCS? If you want install docs for every user, > I must, because of the required copyright.txt file. I see. > > pkg-plist need to be fixed too. > Oh ? sorry. Please remove %%PORTDOCS%% there, I hope that that's all. Yes, that's all. But I found another issue. Could you tell me the reason why you add DIST_SUBDIR here. "blender2.11-freebsd-4.2-i386.tar.gz" has enough information what it is and this port uses only one distfile. I don't think this port requires DIST_SUBDIR. -- FUJISHIMA Satsuki
FUJISHIMA Satsuki wrote: > But I found another issue. Could you tell me the reason why you add > DIST_SUBDIR here. "blender2.11-freebsd-4.2-i386.tar.gz" has enough > information what it is and this port uses only one distfile. I don't > think this port requires DIST_SUBDIR. It's for the next port version, it will have some example files (from different tar balls), some docs maybe, etc. I thought it was better to start using DIST_SUBDIR right away. -- Hans
At Thu, 8 Mar 2001 18:48:00 +0100, Hans Lambermont wrote: > It's for the next port version, it will have some example files (from > different tar balls), some docs maybe, etc. I thought it was better to > start using DIST_SUBDIR right away. OK! That's what I want to know. I've just committed it. -- FUJISHIMA Satsuki
State Changed From-To: open->closed Committed, thanks.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=184291b0a56a68f2c0dc4388419b0f7d85a08cf4 commit 184291b0a56a68f2c0dc4388419b0f7d85a08cf4 Author: Mike Karels <karels@FreeBSD.org> AuthorDate: 2021-06-20 17:50:31 +0000 Commit: Mike Karels <karels@FreeBSD.org> CommitDate: 2021-06-26 16:04:02 +0000 genet: pullup minimum header amount for IPv4 The genet driver (RPi4 Ethernet) had code to pull headers into the first mbuf if there was only an Ethernet header there. This was originally needed for ICMPv6 replies, then for forwarded IPv6/TCP. Now a situation has been found where it is needed for IPv4, when using NAT with IPFW. Generalize to do this for all protocols. Rather than using an IPv6-related definition for the length, move the length to a variable that can be set with sysctl (hw.genet.tx_hdr_min). Move an old tunable to a new RDTUN variable with a better name. PR: 25607 MFC after: 3 days Reviewers: emaste Differential Revision: https://reviews.freebsd.org/D30831 sys/arm64/broadcom/genet/if_genet.c | 53 +++++++++++++++++++++---------------- 1 file changed, 30 insertions(+), 23 deletions(-)
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=2ecf3f2c57749f9968a50a1ce2c2cc29c6f17823 commit 2ecf3f2c57749f9968a50a1ce2c2cc29c6f17823 Author: Mike Karels <karels@FreeBSD.org> AuthorDate: 2021-06-20 17:50:31 +0000 Commit: Mike Karels <karels@FreeBSD.org> CommitDate: 2021-07-05 14:39:48 +0000 genet: pullup minimum header amount for IPv4 The genet driver (RPi4 Ethernet) had code to pull headers into the first mbuf if there was only an Ethernet header there. This was originally needed for ICMPv6 replies, then for forwarded IPv6/TCP. Now a situation has been found where it is needed for IPv4, when using NAT with IPFW. Generalize to do this for all protocols. Rather than using an IPv6-related definition for the length, move the length to a variable that can be set with sysctl (hw.genet.tx_hdr_min). Move an old tunable to a new RDTUN variable with a better name. PR: 25607 Reviewers: emaste Differential Revision: https://reviews.freebsd.org/D30831 (cherry picked from commit 184291b0a56a68f2c0dc4388419b0f7d85a08cf4) sys/arm64/broadcom/genet/if_genet.c | 53 +++++++++++++++++++++---------------- 1 file changed, 30 insertions(+), 23 deletions(-)