Bug 256625 - archivers/snappy: Enable RTTI info
Summary: archivers/snappy: Enable RTTI info
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-15 18:56 UTC by Yuri Victorovich
Modified: 2021-06-16 02:40 UTC (History)
0 users

See Also:
vanilla: maintainer-feedback+

Attachments
patch (2.04 KB, patch)
2021-06-15 18:56 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2021-06-15 18:56:07 UTC 
Created attachment 225834 [details]
patch

devel/folly builds with unresolved symbols because snappy disables RTTI info.
Comment 1 Vanilla I. Shu freebsd_committer freebsd_triage 2021-06-16 01:21:29 UTC 
It's ok to me, please help to commit, thanks.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2021-06-16 02:40:19 UTC 
Committed.

Thanks for a quick approval!
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-06-16 02:40:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=57c66677923080197589551026e400442848491c

commit 57c66677923080197589551026e400442848491c
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2021-06-16 02:36:53 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2021-06-16 02:40:17 +0000

    archivers/snappy: Enable RTTI info

    devel/folly is (silently) built with unresolved symbols because snappy disables RTTI info.
    This later causes www/proxygen build failure.

    PR:             256625
    Approved by:    vanilla (maintainer)

 archivers/snappy/Makefile                   |  1 +
 archivers/snappy/files/patch-CMakeLists.txt | 19 ++++++++++++++++---
 2 files changed, 17 insertions(+), 3 deletions(-)