Bug 256846 - Mk/Uses/firebird.mk: Preparing support for 3.0 and 4.0
Summary: Mk/Uses/firebird.mk: Preparing support for 3.0 and 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-26 17:17 UTC by Jose Alonso Cardenas Marquez
Modified: 2021-06-27 23:31 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2021-06-26 17:17:47 UTC 
Hi, I have a working ports (ready to commit) of firebird30-[client|server] and I'm trying port firebird40 too but it could take more time to commit it

It needs some bit changes into firebird.mk. Could you approve this changes?

https://people.freebsd.org/~acm/ports/firebird.mk.diff

Greetings
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2021-06-27 10:38:52 UTC 
Approved.

This file is maintained by ports@, so no need for explicit portmgr approval, which is mostly for things like bsd.port*.mk or ports maintained by portmgr@ :

bsd.ccache.mk
bsd.commands.mk
bsd.destdir.mk
bsd.licenses.db.mk
bsd.licenses.mk
bsd.port.mk
bsd.port.options.mk
bsd.sanity.mk
bsd.ssp.mk
Scripts/*
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-06-27 23:30:23 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b03649227fd333cad8521db8efae2d28b2acdb53

commit b03649227fd333cad8521db8efae2d28b2acdb53
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2021-06-27 23:26:17 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2021-06-27 23:29:53 +0000

    Mk/Uses/firebird.mk: Prepare support for firebird 3.0 and 4.0

    PR:             256846
    Approved by:    rene

 Mk/Uses/firebird.mk | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)
Comment 3 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2021-06-27 23:31:09 UTC 
I'll take on mind next time. Thanks