I've heard second hand, sorry, I can't help more than that just now. Two dependencies are missing: php-openssl and php-session
And with new information passed to me: this seems to be the minimum * php-openssl * php-session * php-ctype * php-json * php-sqlite3 * php-pdo
The choice of database also needs to be an option. MySQL PostgreSQL SQLite
Ah yes, the php submodules are indeed missing. I don't fully understand your the database comment thought? https://cgit.freebsd.org/ports/tree/www/librespeed/Makefile OPTIONS_RADIO= BACKEND OPTIONS_RADIO_BACKEND= MYSQL PGSQL SQLITE
My apologies, I did not review the Makefile for that. I was passing on what I was being told.
Created attachment 226121 [details] librespeed.diff My poudriere is currently broken but patch fixes at a minimum the missing required dependencies. Would be good if someone could testrun it for me.
I'll see if I can get to this in about 3 hours.
Any objections to adding this into pkg-message: If you want to enable telemetry, you need to enable one of the specific PDO configuration items before building.
If not, I'll include it when committing.
There is already a pkg message for that but it doesn't specify telemetry. "To use the backend feature, be sure to copy a -full example and rebuild the port with backend support." I guess wording can always be improved but the message already captures the core of the idea.
Sorry for that. I should have checked pkg-message. My apologies.
No prob! Was a good suggestion if it wasn't there yet :-).
Feedback from the OP (not me), and I'm paraphrasing - might want to use a slight change of wording there and say "telemetry" because there's non-telemetry stuff in a directory called 'backend' So: To use the backend (i.e. telemetry) feature, be sure to copy a -full example and rebuild the port with backend support.
Ship it!
I tested your patch and was able to build it in my test jail. It installed without errors in that instance. pkg info libargon2-20190702 Memory hard password hashing program and library librespeed-php74-5.2.4_1 Lightweight selfhosted speedtest libxml2-2.9.10_3 XML parser library for GNOME pcre2-10.36 Perl Compatible Regular Expressions library, version 2 php74-7.4.16 PHP Scripting Language php74-ctype-7.4.16 The ctype shared extension for php php74-json-7.4.16 The json shared extension for php php74-openssl-7.4.16 The openssl shared extension for php php74-pdo-7.4.16 The pdo shared extension for php php74-session-7.4.16 The session shared extension for php pkg-1.16.3 Package manager
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0bf5aa7c48694c5d7bfe3855685791d354370813 commit 0bf5aa7c48694c5d7bfe3855685791d354370813 Author: Dan Langille <dvl@FreeBSD.org> AuthorDate: 2021-06-29 21:47:59 +0000 Commit: Dan Langille <dvl@FreeBSD.org> CommitDate: 2021-06-29 21:52:42 +0000 www/librespeed: add missing dependencies Add some PHP dependencies required by this port. Tweak the pkg-message output to hint that telemetry requires configuration settings at build time. PR: 256891 Reported by: dvl www/librespeed/Makefile | 5 ++++- www/librespeed/files/pkg-message.in | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-)
Thank you all for your help.
(In reply to Dan Langille from comment #16) Is quarterly version affected?
A commit in branch 2021Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e34785f48f2eac31014d722e58fa7e84e031245d commit e34785f48f2eac31014d722e58fa7e84e031245d Author: Dan Langille <dvl@FreeBSD.org> AuthorDate: 2021-06-29 21:47:59 +0000 Commit: Dan Langille <dvl@FreeBSD.org> CommitDate: 2021-06-30 00:46:35 +0000 www/librespeed: add missing dependencies Add some PHP dependencies required by this port. Tweak the pkg-message output to hint that telemetry requires configuration settings at build time. PR: 256891 Reported by: dvl (cherry picked from commit 0bf5aa7c48694c5d7bfe3855685791d354370813) www/librespeed/Makefile | 5 ++++- www/librespeed/files/pkg-message.in | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-)
(In reply to Kubilay Kocak from comment #17) Good point. My first mfh on git. Thank you.