Created attachment 226241 [details] textproc/py-pygments: upgrade to 2.9.0 Pygments is lagging, and an upgrade is required to update math/mathicsscript to 3.3.1 (at least to 2.8.0). The proposed patch upgrades to 2.9.0. Release notes at <https://github.com/pygments/pygments/releases/tag/2.9.0>. - Remove conflict with the defunct paraview. - Add a test target (3710 passed, 3 skipped).
Maintainer's time-out.
After a maintainer's time-out, it seems safer to request an exp-run (this port is a run dependency of 62 ports).
@Thierry: py.test may not point where the port needs it to (the python version its being built for, rather than the default). Recommend: ${PYTHON_CMD} -m pytest -v -rs -o addopts= The last arg ensures deterministic pytest environment by overriding anything set in setup.cfg:[pytest] or other places, which often add unecessary things like additional dev dependencies (like pylint), which we don't need downstream)
Created attachment 226682 [details] textproc/py-pygments: upgrade to 2.9.0 New patch, with koobs' suggestion for the test target. Note for Antoine: if you already began the exp-run, no problem, it only affects the test target, no change for the build.
maintainer-feedback set to - after maintainer’s time-out, see Comment 1. Please do not set it back.
Comment on attachment 226682 [details] textproc/py-pygments: upgrade to 2.9.0 ^Triage: Approved by: portmgr (maintainer timeout)
New failure log: http://package18.nyi.freebsd.org/data/122amd64-default-foo/2021-07-26_10h19m12s/logs/errors/openage-0.3.0.1262_5.log
(In reply to Antoine Brodin from comment #7) Thanks to a patch from upstream, openage 0.4.1 supports Pygments 2.9.0. Patch submitted in PR 257471.
Pygments 2.10.0 is available: https://pypi.org/project/Pygments/
Created attachment 231195 [details] update to 2.11.2
New failure log on 13.0 i386: http://package23.nyi.freebsd.org/data/130i386-default-foo/2022-01-22_19h53m43s/logs/openage-0.4.1.log
(In reply to Antoine Brodin from comment #11) I cannot reproduce this failure in my poudrière with Pygments 2.9, it seems that it occurs only with py38-pygments-2.11.2, and the patch committed with openage-0.4.1 was only intended for Pygments 2.9.
Note: an issue has been raised for game/openage, see https://github.com/SFTtech/openage/issues/1397
(In reply to Yuri Victorovich from comment #10) It seems that Pygments-2.11.2 introduced a regression revealed by openage. Then I suggest that we start by updating textproc/py-pygments to 2.9.0 as proposed with my initial patch: everything is clear with it. In a second time, we could submit an another PR to upgrade it to the next version.
(In reply to Thierry Thomas from comment #14) I agree.
(In reply to Yuri Victorovich from comment #15) OK, thanks. Then Antoine, could you please launch an exp-run? (it should be the latest one!)
Created attachment 231844 [details] Upgrade to 2.9.0 Resubmit the previous patch.
Exp-run looks fine
Just committed!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=531a8b3c4af4c6009eaa053a4c991ca4fd0020cf commit 531a8b3c4af4c6009eaa053a4c991ca4fd0020cf Author: Thierry Thomas <thierry@FreeBSD.org> AuthorDate: 2021-07-05 15:32:05 +0000 Commit: Thierry Thomas <thierry@FreeBSD.org> CommitDate: 2022-02-19 15:08:48 +0000 textproc/py-pygments: upgrade to 2.9.0 Release notes at <https://github.com/pygments/pygments/releases/tag/2.9.0>. - Remove conflict with the defunct paraview. - Add a test target (3710 passed, 3 skipped). Exp-run by antoine. PR: 256995 Approved by: maintainer’s time-out textproc/py-pygments/Makefile | 13 ++++++------- textproc/py-pygments/distinfo | 6 +++--- 2 files changed, 9 insertions(+), 10 deletions(-)