Created attachment 226360 [details] qt5-declarative: add missing dependency stage-qa complains that libQt5QuickTest.so.5.15.2 is linked to libQt5Test.so.5 which is not declared as dependency. # readelf -d work/stage/usr/local/lib/qt5/libQt5QuickTest.so.5.15.2 | grep Qt5Test 0x0000000000000001 NEEDED Shared library: [libQt5Test.so.5] The attached patch fixes this.
I'd prefer **not** to have testlib -- a developer-oriented, never-needed-at-runtime Qt component -- installed unless the user actually asks for it **or** there's an application that obviously benefits (e.g. an IDE). That's what current work on **reducing** the dependency burden of Qt and KDE applications is doing. Is QuickTest used for anything? Linked anywhere? Why is it even installed? Those are questions we can ask ourselves before dialling back the reduction in dependencies.
Fair enough. I wasn't aware of the efforts to reduce the dependency burden. On my system, qt5-testlib gets pulled in by quazip-qt5, which is needed by merkaartor: $ pkg info -xr qt5-testlib qt5-testlib-5.15.2_1: qt5-declarative-5.15.2_3 <-- I have my patch applied locally quazip-qt5-1.1 $ pkg info -xr quazip quazip-qt5-1.1: merkaartor-0.18.2_30 $
This missing dependency also breaks wireshark. After upgrading today on a host that does not have kde installed: # pkg autoremove -y Deinstallation has been requested for the following 2 packages: Installed packages to be REMOVED: gtk2: 2.24.33 qt5-testlib: 5.15.2_1 Number of packages to be removed: 2 The operation will free 37 MiB. [1/2] Deinstalling gtk2-2.24.33... [1/2] Deleting files for gtk2-2.24.33: 100% [2/2] Deinstalling qt5-testlib-5.15.2_1... [2/2] Deleting files for qt5-testlib-5.15.2_1: 100% pkg: POST-DEINSTALL script failed # pkg check -d Checking all packages: 100% qt5-declarative is missing a required shared library: libQt5Test.so.5 # pkg info -r qt5-declarative qt5-declarative-5.15.2_3: qt5-multimedia-5.15.2_2 # pkg info -r qt5-multimedia qt5-multimedia-5.15.2_2: wireshark-3.4.6
This is a case of "subpackages would make this *so* easy" and without it's a real pain in the butt. I think this will settle out with QuickTest not being installed (or maybe only as part of a non-default test option) and then hope that there's no actual consumers for it.
Moin moin This should be solved by the creatino of the new port x11-toolkits/qt5-declarative-test [1] mfg Tobias [1] https://cgit.freebsd.org/ports/commit/?id=4d10eef66bb959ed0433df9e065458af4c325552
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9224581a101ea6aa9cfc84002ec344d49b1ee259 commit 9224581a101ea6aa9cfc84002ec344d49b1ee259 Author: Adriaan de Groot <adridg@FreeBSD.org> AuthorDate: 2021-12-17 12:01:36 +0000 Commit: Adriaan de Groot <adridg@FreeBSD.org> CommitDate: 2021-12-17 12:01:36 +0000 x11-toolkits/qt5-declarative: fix testlib-build-failures Since Qt5 testlib tries to be a build-dependency only when needed, and since we build the QML bits without installing the corresponding test-tools, declarative had the following problem: - without testlib installed, would build fine - with testlib installed, would assume the QML test bits are available, and then fail in the build. This is basically our split-up-packaging without subpackages shooting us in the foot; fix the build by removing one more place where testlib leads to the building-of-tests. (The existing patch files/patch-src_src.pro does something similar) PR: 257102 260433 Reported by: Frank Reisert, Philipp Ost x11-toolkits/qt5-declarative/Makefile | 2 +- .../qt5-declarative/files/patch-src_imports_imports.pro (new) | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-)
A commit in branch 2021Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4c2c034e2148bcdb088b0618115efd406ea186ce commit 4c2c034e2148bcdb088b0618115efd406ea186ce Author: Adriaan de Groot <adridg@FreeBSD.org> AuthorDate: 2021-12-17 12:01:36 +0000 Commit: Tobias C. Berner <tcberner@FreeBSD.org> CommitDate: 2021-12-17 13:13:47 +0000 x11-toolkits/qt5-declarative: fix testlib-build-failures Since Qt5 testlib tries to be a build-dependency only when needed, and since we build the QML bits without installing the corresponding test-tools, declarative had the following problem: - without testlib installed, would build fine - with testlib installed, would assume the QML test bits are available, and then fail in the build. This is basically our split-up-packaging without subpackages shooting us in the foot; fix the build by removing one more place where testlib leads to the building-of-tests. (The existing patch files/patch-src_src.pro does something similar) PR: 257102 260433 Reported by: Frank Reisert, Philipp Ost (cherry picked from commit 9224581a101ea6aa9cfc84002ec344d49b1ee259) x11-toolkits/qt5-declarative/Makefile | 2 +- .../qt5-declarative/files/patch-src_imports_imports.pro (new) | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-)