Bug 257225 - www/firefox (1720247) Menu bar menu titles are almost invisible with dark themes in Firefox 90
Summary: www/firefox (1720247) Menu bar menu titles are almost invisible with dark th...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Christoph Moench-Tegeder
URL: https://bugzilla.mozilla.org/show_bug...
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-07-17 01:53 UTC by Graham Perrin
Modified: 2021-07-17 19:18 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gecko)
koobs: merge-quarterly?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2021-07-17 01:53:34 UTC 
Mozilla bug 1720247 affecting me on FreeBSD-CURRENT might be fixed by 
<https://hg.mozilla.org/mozilla-central/rev/cc6f1271888c>

> … 1720441 - Remove unthemed menubar color. r=stransky 

Please consider cherry-picking cc6f1271888c for the next build of www/firefox

Thanks
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-07-17 17:47:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e1a591344ba3f7593c3a2a4697ce08e377f78f97

commit e1a591344ba3f7593c3a2a4697ce08e377f78f97
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2021-07-17 17:45:09 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2021-07-17 17:45:09 +0000

    www/firefox: update to 90.0.1 (rc1)

    Release Notes (soon):
      https://www.mozilla.org/en-US/firefox/90.0.1/releasenotes/

    While here, try to fix menu display in dark mode[1], see
      https://bugzilla.mozilla.org/show_bug.cgi?id=1720441

    PR:             257225 [1]
    Reported by:    Graham Perrin [1]

 www/firefox/Makefile                     |  2 +-
 www/firefox/distinfo                     |  6 ++---
 www/firefox/files/patch-bug1720441 (new) | 38 ++++++++++++++++++++++++++++++++
 3 files changed, 42 insertions(+), 4 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-07-17 17:48:56 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0858bd828885d283406a4c8629a702dd2251deff

commit 0858bd828885d283406a4c8629a702dd2251deff
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2021-07-17 17:45:09 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2021-07-17 17:48:23 +0000

    www/firefox: update to 90.0.1 (rc1)

    Release Notes (soon):
      https://www.mozilla.org/en-US/firefox/90.0.1/releasenotes/

    While here, try to fix menu display in dark mode[1], see
      https://bugzilla.mozilla.org/show_bug.cgi?id=1720441

    PR:             257225 [1]
    Reported by:    Graham Perrin [1]

    (cherry picked from commit e1a591344ba3f7593c3a2a4697ce08e377f78f97)

 www/firefox/Makefile                     |  2 +-
 www/firefox/distinfo                     |  6 ++---
 www/firefox/files/patch-bug1720441 (new) | 38 ++++++++++++++++++++++++++++++++
 3 files changed, 42 insertions(+), 4 deletions(-)
Comment 3 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2021-07-17 17:51:17 UTC 
Hope this helps.
Comment 4 Graham Perrin freebsd_committer freebsd_triage 2021-07-17 19:18:13 UTC 
Thanks! Building now …