Bug 257423 - [NEW PORT] net-p2p/warpinator: Share files across the LAN
Summary: [NEW PORT] net-p2p/warpinator: Share files across the LAN
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL: https://github.com/linuxmint/warpinator
Keywords: feature, needs-qa
Depends on:
Blocks:
 
Reported: 2021-07-26 01:55 UTC by Ivan Rozhuk
Modified: 2024-11-08 13:49 UTC (History)
4 users (show)

See Also:


Attachments
patch (17.07 KB, patch)
2021-07-26 02:31 UTC, Ivan Rozhuk
no flags Details | Diff
patch (7.09 KB, patch)
2022-01-10 06:16 UTC, Ivan Rozhuk
no flags Details | Diff
Bumped patch (7.74 KB, patch)
2023-12-04 15:45 UTC, Vidar Karlsen
no flags Details | Diff
Up-to-date patch (8.69 KB, patch)
2024-07-08 17:27 UTC, Vidar Karlsen
vidar: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2021-07-26 01:55:53 UTC
Warpinator is a kind of AirDrop for devices using Gnu / Linux operating
systems, allowing us to send files to computers that are connected to
the same Wi-Fi network.

Android clients also available in F-Droid and google play.


WWW: https://github.com/linuxmint/warpinator


Patches PR: https://github.com/linuxmint/warpinator/pull/97
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2021-07-26 02:27:52 UTC
(In reply to Ivan Rozhuk from comment #0)
Do you have a patch to add a new port available?
Comment 2 Ivan Rozhuk 2021-07-26 02:31:31 UTC
Created attachment 226697 [details]
patch
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-07-26 10:09:20 UTC
Please use DISTVERSION instead of PORTVERSION (see Porter's Handbook)
If possible please fix so you don't need to set BINARY_ALIAS and submit upstream
Ordering of the lower half of the Makefile can be improved such as SHEBANGFIX*
Comment 4 Ivan Rozhuk 2022-01-10 06:16:13 UTC
Created attachment 230856 [details]
patch

Update to 1.2.9
Comment 5 Vidar Karlsen 2023-11-26 15:39:01 UTC
Is anyone else interested in getting this port committed?
I have 1.6.4 (latest source tag) working.
It's a neat program, I'd like to see it in ports.
Comment 6 Renato Botelho freebsd_committer freebsd_triage 2023-11-29 16:41:36 UTC
(In reply to Vidar Karlsen from comment #5)
Vidar,

I can help to get it added, please submit the patch you have for latest version.

Ivan,

Since you submitted the first version, do you want to be the port maintainer?
Comment 7 Vidar Karlsen 2023-12-04 15:45:35 UTC
Created attachment 246768 [details]
Bumped patch

This is what I have so far, based off of Ivan's original patch.

The protobuf stuff in pre-build is there to avoid having to set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python at runtime because the bundled protos are out of date. This is also why it needs grpcio-tools and protoc in BUILD_DEPENDS.
Comment 8 Renato Botelho freebsd_committer freebsd_triage 2024-01-23 13:39:28 UTC
(In reply to Vidar Karlsen from comment #7)
Hello Vidar and Ivan,

I've added NO_ARCH=yes since this port doesn't carry any binary file.  During build I can see these warnings:

Warning: you may not need USES=desktop-file-utils
Warning: you might not need LIB_DEPENDS on libintl.so
Warning: you might not need LIB_DEPENDS on libatk-1.0.so
Warning: you might not need LIB_DEPENDS on libglib-2.0.so
Warning: you might not need LIB_DEPENDS on libintl.so
Warning: you might not need LIB_DEPENDS on libgtk-3.so
Warning: you might not need LIB_DEPENDS on libpango-1.0.so

Are you sure it requires all listed dependencies?
Comment 9 Vidar Karlsen 2024-01-23 20:50:36 UTC
(In reply to Renato Botelho from comment #8)
I'm not sure. It works without USES=desktop-file-utils.
I think the LIB_DEPENDS come from the other USES= settings, as the port's Makefile doesn't define any LIB_DEPENDS.
Comment 10 Renato Botelho freebsd_committer freebsd_triage 2024-01-24 20:51:54 UTC
(In reply to Vidar Karlsen from comment #9)
Those lib_depends are definitely coming from USES definitions, I was just trying to be sure we are not adding unneeded deps to the list.  Can you just double check on docs if we have just what is needed?

BTW, I had a conversation with Ivan on a private email and he suggested you to assume the maintainership of this port.  Do you agree?
Comment 11 Vidar Karlsen 2024-01-24 21:21:32 UTC
(In reply to Renato Botelho from comment #10)
I'll run some tests and see if I can slim it down.

Regarding maintainership: I don't want to step on anyone's toes, but I'll be happy to maintain it if it's alright with Ivan.
Comment 12 Renato Botelho freebsd_committer freebsd_triage 2024-01-31 18:00:01 UTC
(In reply to Vidar Karlsen from comment #11)
cool.  Thanks!
Comment 13 Vidar Karlsen 2024-07-08 17:27:12 UTC
Created attachment 251938 [details]
Up-to-date patch

Upstream moved to 1.8.5, so I bumped it to there and harmonized the dependencies with the list from the upstream readme (as much as possible).

USES:
I removed desktop-file-utils because the .desktop files don't contain MimeType, and bumped python to :3.8+ since there is no python lower than 3.8 in the tree.

QA:
I've test-built it with poudriere testport under 14.0-amd64 and 13.3-amd64, and directly from the ports tree in 14.0-amd64 and 14.1-amd64.
Run-time tests on 14.0 (jail) and 14.1 (host), sending a file between them worked fine.
Comment 14 commit-hook freebsd_committer freebsd_triage 2024-11-08 13:49:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=882b9da2bd915533c6430b395cc641c91a10cdde

commit 882b9da2bd915533c6430b395cc641c91a10cdde
Author:     Vidar Karlsen <vidar@karlsen.tech>
AuthorDate: 2024-11-08 13:47:29 +0000
Commit:     Renato Botelho <garga@FreeBSD.org>
CommitDate: 2024-11-08 13:48:48 +0000

    net-p2p/warpinator: New port

    Warpinator allows you to easily connect multiple computers on a
    local area network and share files quickly and securely

    PR:             257423

 net-p2p/Makefile                   |   1 +
 net-p2p/warpinator/Makefile (new)  |  46 +++++++++++++++
 net-p2p/warpinator/distinfo (new)  |   3 +
 net-p2p/warpinator/pkg-descr (new) |   2 +
 net-p2p/warpinator/pkg-plist (new) | 117 +++++++++++++++++++++++++++++++++++++
 5 files changed, 169 insertions(+)