Bug 257432 - devel/talloc: Update to 2.3.4 and tweak Makefile
Summary: devel/talloc: Update to 2.3.4 and tweak Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Timur I. Bakeyev
URL:
Keywords:
Depends on:
Blocks: 257442
  Show dependency tree / graph
 
Reported: 2021-07-26 09:38 UTC by Daniel Engberg
Modified: 2022-07-30 00:15 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (timur)

Attachments
Patch for talloc (5.34 KB, patch)
2021-07-26 09:38 UTC, Daniel Engberg 		no flags Details | Diff
Patch for talloc v2 (5.43 KB, patch)
2021-08-01 12:18 UTC, Daniel Engberg 		no flags Details | Diff
talloc v3 (4.98 KB, patch)
2022-06-09 08:26 UTC, Daniel Engberg 		no flags Details | Diff
Patch for talloc v4 (5.53 KB, patch)
2022-06-09 08:33 UTC, Daniel Engberg 		no flags Details | Diff
Patch for talloc v5 (5.57 KB, patch)
2022-06-10 07:40 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-07-26 09:38:03 UTC 
Created attachment 226711 [details]
Patch for talloc

Update talloc to 2.3.3

PORTVERSION --> DISTVERSION
PORTREVISION only needs to be set if it's 1 or higher
Remove tests for multiprocessing python pacakge/module, all versions in tree ships it
Remove very old CONFLITCS entries
Utilize ports framework to remove several if statements
Drop color output settings

Compile and tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-07-26 09:45:54 UTC 
Timur, upstream seems interested in your patch(es) so can you please submit those?
Ref: https://www.spinics.net/lists/samba/msg165532.html

Tests also fail without Python support enabled (hard depend on Python bindings)
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-08-01 12:18:51 UTC 
Created attachment 226837 [details]
Patch for talloc v2

Add missing dependency for Python variant
Strip all libraries
Only include bsd.port.mk
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-09-16 11:53:54 UTC 
Friendly ping
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-06-09 08:26:46 UTC 
Created attachment 234571 [details]
talloc v3

Refresh patch
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-06-09 08:33:31 UTC 
Created attachment 234572 [details]
Patch for talloc v4

Last patch was missing pkg-plist
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2022-06-10 07:40:10 UTC 
Created attachment 234593 [details]
Patch for talloc v5

Update talloc to 2.34

make test passes on FreeBSD 13.1 (amd64)
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2022-06-10 07:42:21 UTC 
Unfortunately upstream doesn't seem to provide release/change notes
https://github.com/samba-team/samba/commits/master/lib/talloc
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-07-30 00:08:45 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dca556afe4ffac103bd8f9b0b451372dcf49b4c8

commit dca556afe4ffac103bd8f9b0b451372dcf49b4c8
Author:     Timur I. Bakeyev <timur@FreeBSD.org>
AuthorDate: 2022-07-29 08:37:06 +0000
Commit:     Timur I. Bakeyev <timur@FreeBSD.org>
CommitDate: 2022-07-30 00:07:41 +0000

    devel/talloc: Update to 2.3.4

    PR:             257432

 devel/talloc/Makefile        | 155 ++++++++++++++++---------------------------
 devel/talloc/distinfo        |   6 +-
 devel/talloc/pkg-plist (new) |  10 +++
 3 files changed, 72 insertions(+), 99 deletions(-)
Comment 9 Timur I. Bakeyev freebsd_committer freebsd_triage 2022-07-30 00:15:22 UTC 
Hi, Daniel!

Same changes to your patch here.

Committed, thank you!

Timur