Bug 257442 - devel/tevent: Update to 0.12.1 and tweak Makefile
Summary: devel/tevent: Update to 0.12.1 and tweak Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Timur I. Bakeyev
URL:
Keywords:
Depends on: 257432
Blocks:
  Show dependency tree / graph
 
Reported: 2021-07-27 00:36 UTC by Daniel Engberg
Modified: 2022-07-30 21:25 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (timur)

Attachments
Patch for tevent (5.14 KB, patch)
2021-07-27 00:36 UTC, Daniel Engberg 		no flags Details | Diff
Patch for tevent v2 (5.24 KB, patch)
2021-08-01 12:15 UTC, Daniel Engberg 		no flags Details | Diff
Patch for tevent v3 (5.27 KB, patch)
2022-06-10 07:44 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-07-27 00:36:27 UTC 
Created attachment 226725 [details]
Patch for tevent

Update (lib)tevent to 0.11.0

PORTVERSION --> DISTVERSION
Use LIB_DEPENDS instead of BUILD_ and RUN_DEPENDS
Remove tests for multiprocessing python pacakge/module, all versions in tree ships it
Remove very old CONFLITCS entry
Utilize ports framework to remove several if statements
Drop color output settings

Compile and tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-07-27 00:37:11 UTC 
Tests also fail without Python support enabled (hard depend on Python bindings)
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-08-01 12:15:22 UTC 
Created attachment 226836 [details]
Patch for tevent v2

Add missing dependency for Python variant
Strip all libraries
Only include bsd.port.mk
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-09-16 11:53:44 UTC 
Friendly ping
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-06-10 07:44:56 UTC 
Created attachment 234594 [details]
Patch for tevent v3

Update to 0.12.1

make test passes on FreeBSD 13.1 (amd64)

Unfortunately upstream doesn't seem to provide release/change notes
https://github.com/samba-team/samba/commits/master/lib/tevent
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-07-30 00:08:44 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ef9a3b42d9a41e6d4ddcfef8abb9e560a1534044

commit ef9a3b42d9a41e6d4ddcfef8abb9e560a1534044
Author:     Timur I. Bakeyev <timur@FreeBSD.org>
AuthorDate: 2022-07-29 12:16:02 +0000
Commit:     Timur I. Bakeyev <timur@FreeBSD.org>
CommitDate: 2022-07-30 00:07:50 +0000

    devel/tevent: Update 0.10.2 to 0.13.0

    PR:             257442

 devel/tevent/Makefile        | 159 ++++++++++++++++++-------------------------
 devel/tevent/distinfo        |   6 +-
 devel/tevent/pkg-plist (new) |   7 ++
 3 files changed, 75 insertions(+), 97 deletions(-)
Comment 6 Timur I. Bakeyev freebsd_committer freebsd_triage 2022-07-30 00:15:33 UTC 
Hi, Daniel!

Same changes to your patch here.

Committed, thank you!

Timur
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2022-07-30 21:25:23 UTC 
No worries, I have a few questions about the final version though.

Why is talloc defined as BUILD and RUN depdency when it's linked?
Any reason why you don't use cmocka in tree?

Why is += used when its the first time the variable is defined?
This is incorrect if you look at Porters Handbook in most cases

Best regards,
Daniel