Bug 257478 - net/asterisk18 G729 files removed in last commit?
Summary: net/asterisk18 G729 files removed in last commit?
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-28 21:09 UTC by OlivierW
Modified: 2021-07-28 22:01 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+
madpilot: merge-quarterly+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description OlivierW 2021-07-28 21:09:39 UTC 
Hello,

Why in the last commit ( https://cgit.freebsd.org/ports/commit/?id=1e67882380f44ebe3ea3a79534df37a0a019768a ), the g729 files have been removed from the distinfo?

I am building asterisk18 with the option G729=on and since the last commit, I am getting a checksum error for those files.

Please have a look at my log file:

=======================<phase: fetch          >============================
===== env: NO_DEPENDS=yes
=> asterisk-18.5.1.tar.gz doesn't seem to exist in /portdistfiles/asterisk.
=> Attempting to fetch https://downloads.asterisk.org/pub/telephony/asterisk//asterisk-18.5.1.tar.gz
asterisk-18.5.1.tar.gz                                  26 MB 8576 kBps    03s
===> Fetching all distfiles required by asterisk18-18.5.1 for building
===========================================================================
=======================<phase: checksum       >============================
===== env: NO_DEPENDS=yes
===> Fetching all distfiles required by asterisk18-18.5.1 for building
=> SHA256 Checksum OK for asterisk/asterisk-18.5.1.tar.gz.
=> No SHA256 checksum recorded for asterisk/asterisk-core-sounds-en-g729-1.5.tar.gz.
=> No suitable checksum found for asterisk/asterisk-core-sounds-en-g729-1.5.tar.gz.
=> No SHA256 checksum recorded for asterisk/asterisk-moh-opsound-g729-2.03.tar.gz.
=> No suitable checksum found for asterisk/asterisk-moh-opsound-g729-2.03.tar.gz.
=> SHA256 Checksum OK for asterisk/traud-asterisk-opus-83e1b458c77e0e287adeca494eeb79edb077b0ff_GH0.tar.gz.
=> SHA256 Checksum OK for asterisk/pjsip-pjproject-2.10_GH0.tar.gz.
*** Error code 1

Stop.
make: stopped in /usr/ports/net/asterisk18
=>> Cleaning up wrkdir
===>  Cleaning for asterisk18-18.5.1
build of net/asterisk18 | asterisk18-18.5.1 ended at Wed Jul 28 22:30:20 CEST 2021
build time: 00:00:09
!!! build failure encountered !!!



In my local poudriere, I have added back those 4 lines in the distinfo file:
SHA256 (asterisk/asterisk-core-sounds-en-g729-1.5.tar.gz) = 8b28a59cfa53b59c76e0a191704f0708e3d83acffab8c5e6f25dfc599f0123f9
SIZE (asterisk/asterisk-core-sounds-en-g729-1.5.tar.gz) = 1551123
SHA256 (asterisk/asterisk-moh-opsound-g729-2.03.tar.gz) = 0147ca9a97f0c550227aacb7793499057c4d2c64e021c95f93722f27d5549585
SIZE (asterisk/asterisk-moh-opsound-g729-2.03.tar.gz) = 1103000

and now it compiles fine again :-)

Best Regards,
Olivier
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2021-07-28 21:37:47 UTC 
Oops, you're right, I removed those by mistake.

Thanks for reporting, going to fix it shortly!
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-07-28 21:50:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5b00c6830a95f8841f24f955d3c3ba9885707786

commit 5b00c6830a95f8841f24f955d3c3ba9885707786
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-07-28 21:47:51 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-07-28 21:47:51 +0000

    net/asterisk16: Add back g729 files distinfo

    I removed these by mistake in commit 99857c53ae27

    PR:             257478
    Reported by:    OlivierW <olivierw1+bugzilla-freebsd@hotmail.com>
    MFH:            2021Q3

 net/asterisk16/distinfo | 4 ++++
 1 file changed, 4 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-07-28 21:50:31 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d2f8bdb85a74ded5cb4e0281a0204330b0223590

commit d2f8bdb85a74ded5cb4e0281a0204330b0223590
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-07-28 21:45:18 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-07-28 21:45:18 +0000

    net/asterisk13: Add back g729 files distinfo

    I removed these by mistake in commit 8b16d6122cdd

    PR:             257478
    Reported by:    OlivierW <olivierw1+bugzilla-freebsd@hotmail.com>
    MFH:            2021Q3

 net/asterisk13/distinfo | 4 ++++
 1 file changed, 4 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-07-28 21:50:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8f0389e64746725f0ed2e73c1a661f2c5d9ca778

commit 8f0389e64746725f0ed2e73c1a661f2c5d9ca778
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-07-28 21:48:45 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-07-28 21:48:45 +0000

    net/asterisk18: Add back g729 files distinfo

    I removed these by mistake in commit 1e67882380f4

    PR:             257478
    Reported by:    OlivierW <olivierw1+bugzilla-freebsd@hotmail.com>
    MFH:            2021Q3

 net/asterisk18/distinfo | 4 ++++
 1 file changed, 4 insertions(+)
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-07-28 21:51:32 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=86780813028f139be19d991b28267468ec46cdce

commit 86780813028f139be19d991b28267468ec46cdce
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-07-28 21:47:51 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-07-28 21:50:26 +0000

    net/asterisk16: Add back g729 files distinfo

    I removed these by mistake in commit 99857c53ae27

    PR:             257478
    Reported by:    OlivierW <olivierw1+bugzilla-freebsd@hotmail.com>
    MFH:            2021Q3

    (cherry picked from commit 5b00c6830a95f8841f24f955d3c3ba9885707786)

 net/asterisk16/distinfo | 4 ++++
 1 file changed, 4 insertions(+)
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-07-28 21:51:33 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5af1e630edc3645297d8a16df929072633b1b6ac

commit 5af1e630edc3645297d8a16df929072633b1b6ac
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-07-28 21:48:45 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-07-28 21:50:33 +0000

    net/asterisk18: Add back g729 files distinfo

    I removed these by mistake in commit 1e67882380f4

    PR:             257478
    Reported by:    OlivierW <olivierw1+bugzilla-freebsd@hotmail.com>
    MFH:            2021Q3

    (cherry picked from commit 8f0389e64746725f0ed2e73c1a661f2c5d9ca778)

 net/asterisk18/distinfo | 4 ++++
 1 file changed, 4 insertions(+)
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-07-28 21:51:34 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=03e5d361978178dc021bb8a68ad2555f4a23d35d

commit 03e5d361978178dc021bb8a68ad2555f4a23d35d
Author:     Guido Falsi <madpilot@FreeBSD.org>
AuthorDate: 2021-07-28 21:45:18 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2021-07-28 21:50:20 +0000

    net/asterisk13: Add back g729 files distinfo

    I removed these by mistake in commit 8b16d6122cdd

    PR:             257478
    Reported by:    OlivierW <olivierw1+bugzilla-freebsd@hotmail.com>
    MFH:            2021Q3

    (cherry picked from commit d2f8bdb85a74ded5cb4e0281a0204330b0223590)

 net/asterisk13/distinfo | 4 ++++
 1 file changed, 4 insertions(+)
Comment 8 Guido Falsi freebsd_committer freebsd_triage 2021-07-28 21:52:45 UTC 
Distinfo lines added back.

Thanks again for reporting.
Comment 9 OlivierW 2021-07-28 22:01:20 UTC 
Nice! Thanks a lot! :-)