Bug 257646 - opensm: rc service is installed by default, but opensm(8) is not (WITH_OFED_EXTRA)
Summary: opensm: rc service is installed by default, but opensm(8) is not (WITH_OFED_E...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 13.0-RELEASE
Hardware: amd64 Any
: --- Affects Many People
Assignee: Mark Johnston
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-06 02:16 UTC by metsuke
Modified: 2024-12-24 16:36 UTC (History)
6 users (show)

See Also:
markj: mfc-stable14-
markj: mfc-stable13-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description metsuke 2021-08-06 02:16:32 UTC
/usr/bin/opensm appears to be missing:


    # service opensm start
    Starting 0x0202c9fffe318b00 opensm.
    eval: /usr/bin/opensm: not found
    Starting 0x0202c9fffe318b01 opensm.
    eval: /usr/bin/opensm: not found


The service can no longer be started now.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-06 02:46:01 UTC
@Reporter, If additional information can be provided, please re-open the issue. Please include at least:

- Exact FreeBSD version (uname -a output)
- /var/run/dmesg.boot output (as an attachment)
- Contents of /etc/make.conf /etc/src.conf and /etc/src-env.conf if not empty
- If running a non GENERIC kernel, full kernel config (as an attachment)
- Any other details relevent to the system in question.
Comment 2 Mark Johnston freebsd_committer freebsd_triage 2021-08-06 03:09:05 UTC
The problem is pretty clear:

$ which opensm
$

The opensm build is disabled unless one builds world with WITH_OFED_EXTRA:
https://cgit.freebsd.org/src/commit/?id=abbe7d5acd14dddbf8506f2e1f47d6dd953756fb

I'm not sure why opensm is considered non-essential, at least one host needs to run an SM.  I guess it is most common to run it on a switch?  At least, rc.d/opensm should not be installed by default.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-06 03:14:28 UTC
^Triage: Re-open given additional detail
Comment 4 metsuke 2021-08-06 03:22:36 UTC
@koobs Let me know if I should still provide additional details you requested, thanks.

I am on 13.0-RELEASE-p3:
13.0-RELEASE-p3 FreeBSD 13.0-RELEASE-p3 #0: Tue Jun 29 19:46:20 UTC 2021     root@amd64-builder.daemonology.net:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64
Comment 5 Konstantin Belousov freebsd_committer freebsd_triage 2021-08-06 03:51:57 UTC
(In reply to Mark Johnston from comment #2)
WITH_OFED enables only essential core libraries needed to run rdma applications.
Anything more, like test utilities, management utilities, or subnet manager,
is put under _EXTRA because if you need this, you would recompile base anyway.
Comment 6 Mina Galić freebsd_triage 2023-04-11 23:50:12 UTC
unfortunately, disabling it by default means it easily slips into not building at all, not just by default: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270776
Comment 7 Mark Linimon freebsd_committer freebsd_triage 2024-10-04 12:49:58 UTC
^Triage: clear unneeded flags.  Nothing has yet been committed to be merged.
Comment 8 commit-hook freebsd_committer freebsd_triage 2024-10-29 13:02:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=207ab5f4f1ebcbfd6f3f2ab619baf08862d0d08d

commit 207ab5f4f1ebcbfd6f3f2ab619baf08862d0d08d
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2024-10-29 13:01:00 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-10-29 13:01:00 +0000

    rc.d/opensm: Only install when MK_OFED_EXTRA is set

    opensm itself is only installed when MK_OFED_EXTRA is set, so it only
    makes sense for the same to be true of the rc script.

    PR:             257646
    Reviewed by:    kib
    Differential Revision:  https://reviews.freebsd.org/D47313

 libexec/rc/rc.d/Makefile                 | 2 +-
 tools/build/mk/OptionalObsoleteFiles.inc | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Comment 9 Mark Linimon freebsd_committer freebsd_triage 2024-11-04 21:08:28 UTC
^Triage: over to committer.