Bug 257662 - sysutils/gnome-control-center: 40.0 (e247fd33c) fails to build
Summary: sysutils/gnome-control-center: 40.0 (e247fd33c) fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL: https://gitlab.gnome.org/GNOME/gnome-...
Keywords: needs-qa, regression
Depends on:
Blocks: 257663
  Show dependency treegraph
 
Reported: 2021-08-06 16:30 UTC by Matthias Andree
Modified: 2021-08-06 17:01 UTC (History)
0 users

See Also:
mandree: maintainer-feedback-


Attachments
full poudriere log, xz-compressed (23.55 KB, application/x-xz)
2021-08-06 16:30 UTC, Matthias Andree
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2021-08-06 16:30:05 UTC
Created attachment 226994 [details]
full poudriere log, xz-compressed

Hi Neel,

gnome-control-center does not build for me in poudriere with a ports tree at Git version 9abe0ca32. 

Below is the error I get, full log attached.

[00:01:39] FAILED: panels/power/libpower.a.p/cc-power-panel.c.o 
[00:01:39] cc -Ipanels/power/libpower.a.p -Ipanels/power -I../panels/power -I. -I.. -Ipanels/common -I../panels/common -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/gsettings-desktop-schemas -I/usr/local/include/libhandy-1 -I/usr/local/include/gtk-3.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/harfbuzz -I/usr/local/include/freetype2 -I/usr/local/include/fribidi -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/libpng16 -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/gio-unix-2.0 -I/usr/local/include/libepoll-shim -I/usr/local/include/atk-1.0 -I/usr/local/include/at-spi2-atk/2.0 -I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include -I/usr/local/include/at-spi-2.0 -I/usr/local/include/gnome-settings-daemon-3.0 -I/usr/local/include/libupower-glib -fno-color-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -DHAVE_CONFIG_H -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -fPIC -pthread -D_THREAD_SAFE '-DG_LOG_DOMAIN="power-cc-panel"' '-DPANEL_ID="power"' -MD -MQ panels/power/libpower.a.p/cc-power-panel.c.o -MF panels/power/libpower.a.p/cc-power-panel.c.o.d -o panels/power/libpower.a.p/cc-power-panel.c.o -c ../panels/power/cc-power-panel.c
[00:01:39] ../panels/power/cc-power-panel.c:1748:58: error: use of undeclared identifier 'mobile_switch_changed_cb'
[00:01:39]   gtk_widget_class_bind_template_callback (widget_class, mobile_switch_changed_cb);
[00:01:39]                                                          ^
[00:01:39] ../panels/power/cc-power-panel.c:1752:58: error: use of undeclared identifier 'wifi_switch_changed_cb'
[00:01:39]   gtk_widget_class_bind_template_callback (widget_class, wifi_switch_changed_cb);
[00:01:39]                                                          ^
[00:01:39] 2 errors generated.
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2021-08-06 16:48:48 UTC
Further findings:

1. guarding these two lines with #ifdef HAVE_NETWORKMANAGER .. #endif fixes the immediate issue, and may need to be forwarded upstream.

2. the build apparently picks up Kerberos "from somewhere" in a build outside poudriere:

Error: /usr/local/bin/gnome-control-center is linked to /usr/local/lib/samba4/libsmbclient.so.0 which does not have a SONAME.  net/samba412 needs to be fixed.

Error: /usr/local/bin/gnome-control-center is linked to /usr/local/lib/libkrb5.so.3.3 from security/krb5 but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libkrb5.so:security/krb5

I'll clone #2 into a separate bug and fix #1 now.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-08-06 16:49:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=35b99cbcd7b1b3ec5d8ab3995efb6dc52cc2246e

commit 35b99cbcd7b1b3ec5d8ab3995efb6dc52cc2246e
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2021-08-06 16:45:54 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-08-06 16:45:54 +0000

    sysutils/gnome-control-center: Fix 40.0 build error

    [00:01:39] ../panels/power/cc-power-panel.c:1748:58: error: use of undeclared identifier 'mobile_switch_changed_cb'
    [00:01:39]   gtk_widget_class_bind_template_callback (widget_class, mobile_switch_changed_cb);
    [00:01:39]                                                          ^
    [00:01:39] ../panels/power/cc-power-panel.c:1752:58: error: use of undeclared identifier 'wifi_switch_changed_cb'
    [00:01:39]   gtk_widget_class_bind_template_callback (widget_class, wifi_switch_changed_cb);
    [00:01:39]                                                          ^
    [00:01:39] 2 errors generated.

    PR:             257662
    Approved by:    portmgr (implicit, fixing broken build)

 .../files/patch-panels_power_cc-power-panel.c (new)    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Comment 3 Matthias Andree freebsd_committer freebsd_triage 2021-08-06 17:01:15 UTC
No need to forward upstream, Gentoo reported this and upstream used the same fix, see https://gitlab.gnome.org/GNOME/gnome-control-center/-/commit/d9ea8554088ed225d603917bb3955b03e344dc4d