Bug 257913 - graphics/tumble: patch and unbreak with -fno-common
Summary: graphics/tumble: patch and unbreak with -fno-common
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/brouhaha/tumble/is...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-17 13:07 UTC by Robert Clausecker
Modified: 2021-08-19 06:22 UTC (History)
1 user (show)

See Also:
fernape: merge-quarterly+

Attachments
graphics/tumble: patch and unbreak with -fno-common (2.37 KB, patch)
2021-08-17 13:07 UTC, Robert Clausecker 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-08-17 13:07:03 UTC 
Created attachment 227282 [details]
graphics/tumble: patch and unbreak with -fno-common

This fixes the build on FreeBSD 13 and newer systems. The issue has been reported upstream, too.

Expand list of big endian architectures for which this port won't work.

Also take over maintainership.

Tested with Poudriere on amd64 FreeBSD 13.0-RELEASE and without Poudriere on arm64 FreeBSD 13.0-RELEASE.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-08-19 06:19:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9ff864cb14876ee8dba7900e3afb7169e449b5f4

commit 9ff864cb14876ee8dba7900e3afb7169e449b5f4
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-08-18 08:57:32 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2021-08-19 06:14:01 +0000

    graphics/tumble: Unbreak with -fno-common

    Submitter becomes MAINTAINER. Already maintainer of several ports.

    Ref: https://github.com/brouhaha/tumble/issues/10

    PR:     257913
    MFH:    2021Q3

 graphics/tumble/Makefile                          | 11 +++++------
 graphics/tumble/files/patch-semantics.c (new)     | 11 +++++++++++
 graphics/tumble/files/patch-tumble__input.h (new) |  8 ++++++++
 3 files changed, 24 insertions(+), 6 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-08-19 06:21:37 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b5a7b4433120ded99f75c64b69b3c94224608728

commit b5a7b4433120ded99f75c64b69b3c94224608728
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-08-18 08:57:32 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2021-08-19 06:16:25 +0000

    graphics/tumble: Unbreak with -fno-common

    Submitter becomes MAINTAINER. Already maintainer of several ports.

    Ref: https://github.com/brouhaha/tumble/issues/10

    PR:     257913
    MFH:    2021Q3
    (cherry picked from commit 9ff864cb14876ee8dba7900e3afb7169e449b5f4)

 graphics/tumble/Makefile                          | 11 +++++------
 graphics/tumble/files/patch-semantics.c (new)     | 11 +++++++++++
 graphics/tumble/files/patch-tumble__input.h (new) |  8 ++++++++
 3 files changed, 24 insertions(+), 6 deletions(-)
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2021-08-19 06:22:13 UTC 
Committed,

Thanks!