Bug 258030 - security/pecl-scrypt: fix build with php80
Summary: security/pecl-scrypt: fix build with php80
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Danilo G. Baio
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-08-24 20:15 UTC by clpo13
Modified: 2021-08-25 12:35 UTC (History)
0 users

See Also:
dbaio: maintainer-feedback+

Attachments
php80-pecl-scrypt-1.4.2.patch (2.55 KB, patch)
2021-08-24 20:15 UTC, clpo13 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description clpo13 2021-08-24 20:15:09 UTC 
Created attachment 227413 [details]
php80-pecl-scrypt-1.4.2.patch

This patch should get the port working with php80. Mostly cribbed from https://github.com/DomBlack/php-scrypt/commit/3b01fd422300032d2ba91f978d8c9131fa519b72.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-08-25 12:28:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a5d11eeb395da6b6b8af01206765173d0fb1bfe5

commit a5d11eeb395da6b6b8af01206765173d0fb1bfe5
Author:     Danilo G. Baio <dbaio@FreeBSD.org>
AuthorDate: 2021-08-25 12:25:15 +0000
Commit:     Danilo G. Baio <dbaio@FreeBSD.org>
CommitDate: 2021-08-25 12:27:30 +0000

    security/pecl-scrypt: Fix build with PHP 8

    PR:             258030
    Reported by:    clpo13@gmail.com

 security/pecl-scrypt/Makefile                                |  5 ++++-
 security/pecl-scrypt/distinfo                                |  4 +++-
 .../files/patch-crypto_crypto__scrypt-nosse.c (new)          | 12 ++++++++++++
 3 files changed, 19 insertions(+), 2 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-08-25 12:33:58 UTC 
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0370ede7f5598c41c2d015be876a651b1f4ebdf1

commit 0370ede7f5598c41c2d015be876a651b1f4ebdf1
Author:     Danilo G. Baio <dbaio@FreeBSD.org>
AuthorDate: 2021-08-25 12:25:15 +0000
Commit:     Danilo G. Baio <dbaio@FreeBSD.org>
CommitDate: 2021-08-25 12:32:45 +0000

    security/pecl-scrypt: Fix build with PHP 8

    PR:             258030
    Reported by:    clpo13@gmail.com

    (cherry picked from commit a5d11eeb395da6b6b8af01206765173d0fb1bfe5)

 security/pecl-scrypt/Makefile                                |  5 ++++-
 security/pecl-scrypt/distinfo                                |  4 +++-
 .../files/patch-crypto_crypto__scrypt-nosse.c (new)          | 12 ++++++++++++
 3 files changed, 19 insertions(+), 2 deletions(-)
Comment 3 Danilo G. Baio freebsd_committer freebsd_triage 2021-08-25 12:35:28 UTC 
Committed with a few changes. And thank you!