Bug 258163 - devel/godot-tools: requires binutils to build on armv7 FreeBSD 13
Summary: devel/godot-tools: requires binutils to build on armv7 FreeBSD 13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-30 08:00 UTC by Robert Clausecker
Modified: 2021-09-04 11:43 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+
tcberner: maintainer-feedback+
fuz: merge-quarterly?


Attachments
godot-tools-3.2.3_3 build log (167.74 KB, application/x-xz)
2021-08-30 08:00 UTC, Robert Clausecker
no flags Details
maintainer update for devel/godot (1.61 KB, patch)
2021-09-01 05:14 UTC, Shane
FreeBSD: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-08-30 08:00:39 UTC
Created attachment 227551 [details]
godot-tools-3.2.3_3 build log

On armv7 FreeBSD 13.0-RELEASE, building devel/godot-tools fails due to a missing as binary:

as -mfpu=neon -o thirdparty/libvpx/vpx_dsp/arm/gas/intrapred_neon_asm.x11.opt.tools.32.llvm.o thirdparty/libvpx/vpx_dsp/arm/gas/intrapred_neon_asm.s
sh: as: not found
scons: *** [thirdparty/libvpx/vpx_dsp/arm/gas/intrapred_neon_asm.x11.opt.tools.32.llvm.o] Error 127
scons: building terminated because of errors.
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/godot-tools


As the GNU binutils (which provide the as binary) are no longer shipped by default, an explicit build dependency on the GNU binutils needs to be added to fix this issue.

If desired I can try and make a patch.
Comment 1 Shane 2021-09-01 05:14:26 UTC
Created attachment 227582 [details]
maintainer update for devel/godot

Actually I think its time we just remove the use of the internal libvpx for all arches
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2021-09-04 11:12:00 UTC
(In reply to Shane from comment #1)

I believe PORTREVISION needs to be bumped with this sort of change.  What do you think?
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2021-09-04 11:21:43 UTC
Maintaner approved patch, so mark feedback as "+".
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2021-09-04 11:38:43 UTC
(In reply to Robert Clausecker from comment #2)
No need to PORTREVERSION bump here; as far as I can see the package for the other architectures remains unchanged. For the affected ones armv7, ... there never was a package with the wrong dependencies (as it did not build).



mfg Tobias
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-09-04 11:41:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=aeed33b9c143a27ed397bb7c51c5b60383328df1

commit aeed33b9c143a27ed397bb7c51c5b60383328df1
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-09-04 11:35:44 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-09-04 11:39:26 +0000

    devel/godot: fix build of devel/godot-tools on armv7

    Switch to always using libvpx from ports.

    PR:             258163
    Approved by:    FreeBSD@ShaneWare.Biz (maintainer)

 devel/godot/Makefile | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)
Comment 6 Tobias C. Berner freebsd_committer freebsd_triage 2021-09-04 11:43:54 UTC
Committed. Thanks