Bug 258756 - sysutils/gomplate: Update to 3.10.0
Summary: sysutils/gomplate: Update to 3.10.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-28 08:36 UTC by Nuno Teixeira
Modified: 2022-05-09 07:27 UTC (History)
1 user (show)

See Also:


Attachments
incomplete update diff (31.15 KB, patch)
2021-09-28 08:36 UTC, Nuno Teixeira
no flags Details | Diff
patch file (24.73 KB, patch)
2022-05-05 23:06 UTC, Dmitri Goutnik
dmgk: maintainer-approval?
eduardo: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2021-09-28 08:36:34 UTC
Created attachment 228227 [details]
incomplete update diff

Hello,

After refreshing GH_TUPLE with 'make gomod-vendor' some dependencies could not be fetched.

This update diff end in error 'make makesum':
---
=> go4org-go4-1025295fd063_GH0.tar.gz doesn't seem to exist in /tmp/.
=> Attempting to fetch https://codeload.github.com/go4org/go4/tar.gz/1025295fd063?dummy=/go4org-go4-1025295fd063_GH0.tar.gz
fetch: https://codeload.github.com/go4org/go4/tar.gz/1025295fd063?dummy=/go4org-go4-1025295fd063_GH0.tar.gz: Not Found
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/go4org-go4-1025295fd063_GH0.tar.gz
fetch: http://distcache.FreeBSD.org/ports-distfiles/go4org-go4-1025295fd063_GH0.tar.gz: Not Found
=> Couldn't fetch it - please try to retrieve this
=> port manually into /tmp/ and try again.
---

GH_TUPLE:
---
(...)
go4org:go4:1025295fd063:go4org_go4_1/vendor/go4.org/unsafe/assume-no-moving-gc \
go4org:go4:3eb7198706b2:go4org_go4/vendor/go4.org/intern \
(...)
---

go4org exists in: https://github.com/go4org/go4/
https://codeload.github.com/go4org/go4/tar.gz/1025295fd063?dummy=/go4org-go4-1025295fd063_GH0.tar.gz gives 404 "Not found"

Any hints on how to fix this?
Comment 1 Dmitri Goutnik freebsd_committer freebsd_triage 2022-05-05 23:06:30 UTC
Created attachment 233754 [details]
patch file

The easiest fix probably would be to switch to GO_MODULE (also updated to the latest 3.10.0 release).
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-05-08 11:11:53 UTC
Comment on attachment 233754 [details]
patch file

Hello,

Thanks for the hint!

poudriere test builds ok on all available releases: 140, 130, 123 (amd64/i386)

On my pc I have to add an variable so that program works:

ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.18

Thanks,

Nuno Teixeira
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-05-08 11:37:44 UTC
For what I know is that this method doesn't work on all go ports. I've tried this method on security/gopass and it couldn't fetch.
I'm having same problem with this port because it gives XML errors when fetching (traditional method) go modules.

I will try to continue finding a solution for this one.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-05-08 11:39:19 UTC
I think this update can be committed, will you comiit it or shhould I commit it?

Thanks
Comment 5 Dmitri Goutnik freebsd_committer freebsd_triage 2022-05-08 11:59:16 UTC
(In reply to Nuno Teixeira from comment #4)
Please commit it, as you're the maintainer. I'll take a look at gopass.
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-05-09 07:26:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=af540affdf0639c1deea4e9146ddf7a6e80e5abf

commit af540affdf0639c1deea4e9146ddf7a6e80e5abf
Author:     Dmitri Goutnik <dmgk@freebsd.org>
AuthorDate: 2022-05-09 07:19:44 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-05-09 07:19:44 +0000

    sysutils/gomplate: Update to 3.10.0

     - Use GO_MODULE method

    ChangeLog: https://github.com/hairyhenderson/gomplate/releases/tag/v3.10.0

    PR:             258756

 sysutils/gomplate/Makefile | 112 +-------------------------
 sysutils/gomplate/distinfo | 196 ++-------------------------------------------
 2 files changed, 8 insertions(+), 300 deletions(-)
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2022-05-09 07:27:40 UTC
Commited, thanks!