Bug 258832 - devel/grex: Update to version 1.3.0
Summary: devel/grex: Update to version 1.3.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/pemistahl/grex/rel...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-01 09:22 UTC by Petteri Valkonen
Modified: 2021-10-08 08:18 UTC (History)
2 users (show)

See Also:
petteri.valkonen: maintainer-feedback+

Attachments
Patch to update grex to version 1.3.0 (32.88 KB, patch)
2021-10-01 09:22 UTC, Petteri Valkonen 		no flags Details | Diff
Patch to update grex to version 1.3.0 (30.96 KB, patch)
2021-10-07 14:58 UTC, Petteri Valkonen 		petteri.valkonen: maintainer-approval+
Details | Diff
Patch to update grex to version 1.3.0 (31.18 KB, patch)
2021-10-08 07:42 UTC, Petteri Valkonen 		petteri.valkonen: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Valkonen 2021-10-01 09:22:44 UTC 
Created attachment 228309 [details]
Patch to update grex to version 1.3.0
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2021-10-07 08:50:54 UTC 
Hello,

CARGO_CRATES list is not correctly formated.

Please see https://docs.freebsd.org/en/books/porters-handbook/special/#using-cargo

You can use 'make cargo-crates > cargo-crates.list" and then copy and paste list into Makefile exactly as it appears.
Comment 2 Petteri Valkonen 2021-10-07 14:58:35 UTC 
Created attachment 228499 [details]
Patch to update grex to version 1.3.0

Thanks for noticing, patch updated.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2021-10-08 07:37:44 UTC 
CARGO_CRATES list is fine.

Just 2 more small fixes:

1. Use a tab after DISTVERSIONPREFIX=

2. Alphabetical order in PORTDOCS

---
+DISTVERSIONPREFIX=     v
-DISTVERSIONPREFIX=v
 DISTVERSION=   1.3.0
 CATEGORIES=    devel

@@ -101,7 +101,7 @@
 PLIST_FILES=   bin/grex

 OPTIONS_DEFINE=        DOCS
+PORTDOCS=      README.md RELEASE_NOTES.md
-PORTDOCS=      RELEASE_NOTES.md README.md
---
Comment 4 Petteri Valkonen 2021-10-08 07:42:33 UTC 
Created attachment 228513 [details]
Patch to update grex to version 1.3.0

Patch updated.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-10-08 08:18:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=90cf090f10e499e45843c530e356fb181c33ca24

commit 90cf090f10e499e45843c530e356fb181c33ca24
Author:     Petteri Valkonen <petteri.valkonen@iki.fi>
AuthorDate: 2021-10-08 08:15:38 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2021-10-08 08:17:16 +0000

    devel/grex: Update to version 1.3.0

    ChangeLog: https://github.com/pemistahl/grex/releases/tag/v1.3.0

    PR:             258832

 devel/grex/Makefile |  54 ++++----
 devel/grex/distinfo | 352 ++++++++++++++++++++++++++--------------------------
 2 files changed, 198 insertions(+), 208 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2021-10-08 08:18:52 UTC 
Committed thanks!