Bug 258950 - sysutils/py-diffoscope: Update to 186
Summary: sysutils/py-diffoscope: Update to 186
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guangyuan Yang
URL: https://diffoscope.org/news/diffoscop...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-05 16:38 UTC by Guangyuan Yang
Modified: 2021-10-06 03:32 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (koobs)
ygy: merge-quarterly-


Attachments
Proposed patch (974 bytes, text/plain)
2021-10-05 16:38 UTC, Guangyuan Yang
koobs: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guangyuan Yang freebsd_committer freebsd_triage 2021-10-05 16:38:31 UTC
Created attachment 228466 [details]
Proposed patch
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-05 23:42:29 UTC
Thanks Guangyuan,

Does this pass QA [1] including no change on make test?

https://wiki.freebsd.org/KubilayKocak#MAINTAINER_POLICY
Comment 2 Guangyuan Yang freebsd_committer freebsd_triage 2021-10-05 23:55:38 UTC
(In reply to Kubilay Kocak from comment #1)

It passes QA and some quick manual testing. The test suite reports some failures which are the same as the current version (no regressions). Several versions have been skipped from 175 -> 186 which includes new features, so I don't recommend MFH this.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-06 00:12:47 UTC
(In reply to Guangyuan Yang from comment #2)

If the dependency set has not changed between versions, this is one of those ports in a category where version bumps and new features exclusively improve the current state of the software, in particular as they also fix bugs. diffoscope's only aim is to identify reproducibility issues and the state of that only moves forward.

I'd prefer a merge if you don't mind doing so (I take an opt-out approach)

Thank you for submitting the update :) If this addresses all the items in MAINTAINER_POLICY you are free to self-assign and resolve at any time
Comment 4 Guangyuan Yang freebsd_committer freebsd_triage 2021-10-06 00:34:02 UTC
(In reply to Kubilay Kocak from comment #3)

> If the dependency set has not changed between versions, this is one of those ports in a category where version bumps and new features exclusively improve the current state of the software, in particular as they also fix bugs. diffoscope's only aim is to identify reproducibility issues and the state of that only moves forward.

> I'd prefer a merge if you don't mind doing so (I take an opt-out approach)

Thanks for your detailed explanation. I understand that most software projects work towards a goal of improving the current state in their new releases, however, behaviours may change and bugs may be introduced while new features are added, which sounds contradict the point of having a quarterly branch; so this reasoning is not convincing enough for me to merge this update of 11 releases (175 -> 186) to quarterly, unless if there is some other strong compelling reason to do so.

I will need an explicit maintainer-feedback (+) flag in order to commit it, thanks!
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-06 01:04:42 UTC
Comment on attachment 228466 [details]
Proposed patch

Approved by: koobs (maintainer)
MFH: No (feature releases)

Please include a changelog link in the commit log message
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-10-06 03:31:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c6e7d6db24f93fb40bbf53ce9a7e6358b254d101

commit c6e7d6db24f93fb40bbf53ce9a7e6358b254d101
Author:     Guangyuan Yang <ygy@FreeBSD.org>
AuthorDate: 2021-10-06 03:30:57 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-10-06 03:30:57 +0000

    sysutils/py-diffoscope: Update to 186

    Changes:        https://diffoscope.org/news/diffoscope-186-released/

    PR:             258950
    Approved by:    koobs (maintainer)

 sysutils/py-diffoscope/Makefile | 2 +-
 sysutils/py-diffoscope/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)