Bug 258955 - net-im/scli: no longer fetches (Github updates to .tar.gz generator?)
Summary: net-im/scli: no longer fetches (Github updates to .tar.gz generator?)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-05 20:51 UTC by Matthias Andree
Modified: 2021-12-31 21:13 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (0mp)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2021-10-05 20:51:46 UTC
scli no longer fetches, and since the distinfo file hasn't been touched in three months, I surmise that Gitlab might have changed how .tar.gz files are auto-rolled.  See below.

I think we need to 
1. investigate the differences and determine if it's safe to just update distinfo, and if so, update.
2. check how to avoid such failures in the future (possibly with the gurus who added Github stuff to bsd.sites*mk)


[/usr/ports/net-im/scli]$ make checksum
===>  License GPLv3 accepted by the user
===>   scli-0.6.4_2 depends on file: /usr/local/sbin/pkg - found
=> isamert-scli-v0.6.4_GH0.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://codeload.github.com/isamert/scli/tar.gz/v0.6.4?dummy=/isamert-scli-v0.6.4_GH0.tar.gz
fetch: https://codeload.github.com/isamert/scli/tar.gz/v0.6.4?dummy=/isamert-scli-v0.6.4_GH0.tar.gz: size unknown
fetch: https://codeload.github.com/isamert/scli/tar.gz/v0.6.4?dummy=/isamert-scli-v0.6.4_GH0.tar.gz: size of remote file is not known
isamert-scli-v0.6.4_GH0.tar.gz                         136 kB 2859 kBps    00s
=> Fetched file size mismatch (expected 139743, actual 139732)
=> Trying next site
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/isamert-scli-v0.6.4_GH0.tar.gz
fetch: http://distcache.FreeBSD.org/ports-distfiles/isamert-scli-v0.6.4_GH0.tar.gz: Not Found
=> Couldn't fetch it - please try to retrieve this
=> port manually into /usr/ports/distfiles/ and try again.
*** Error code 1

Stop.
make: stopped in /usr/ports/net-im/scli
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-10-06 07:17:37 UTC
Thanks for the report. I've asked the upstream about it. See https://github.com/isamert/scli/issues/143.
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-10-07 10:07:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1421ae7eb67cb994cee5784d97fa313274afa78c

commit 1421ae7eb67cb994cee5784d97fa313274afa78c
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2021-10-07 09:59:18 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2021-10-07 09:59:18 +0000

    net-im/scli: Update distinfo

    GitHub seemed to regenerate the tarball, which changed its hash and
    size. The contents are the same.

    PR:             258955
    Reported by:    mandree

 net-im/scli/distinfo | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-10-07 10:16:17 UTC
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8c778c523fc3f8aceed78507b53c4cc8059a6557

commit 8c778c523fc3f8aceed78507b53c4cc8059a6557
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2021-10-07 09:59:18 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2021-10-07 10:15:19 +0000

    net-im/scli: Update distinfo

    GitHub seemed to regenerate the tarball, which changed its hash and
    size. The contents are the same.

    PR:             258955
    Reported by:    mandree

    (cherry picked from commit 1421ae7eb67cb994cee5784d97fa313274afa78c)

 net-im/scli/distinfo | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2021-10-07 10:18:10 UTC
When it comes to your second question, I'm not sure if we can avoid this problem if we are relying on autogenerated tarballs. See https://github.com/isamert/scli/issues/143#issuecomment-937595274