Created attachment 228812 [details] disconnect lorder from the build lorder serves no purpose on contemporary FreeBSD and may be removed in the future. Let's see if any ports make use of it.
Failure logs containing lorder errors: http://gohan04.nyi.freebsd.org/data/main-amd64-PR259254-default/2021-10-19_18h30m01s/logs/cdrdao-1.2.4_3.log http://gohan04.nyi.freebsd.org/data/main-amd64-PR259254-default/2021-10-19_18h30m01s/logs/iconv-2.0_4.log http://gohan04.nyi.freebsd.org/data/main-amd64-PR259254-default/2021-10-19_18h30m01s/logs/libcidr-1.2.3.log http://gohan04.nyi.freebsd.org/data/main-amd64-PR259254-default/2021-10-19_18h30m01s/logs/symon-2.87.log
Created attachment 228928 [details] remove use of lorder from converters/iconv
converters/iconv review: https://reviews.freebsd.org/D32593 bland@ does not seem to have a Phabricator account, so attaching patch here.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3e01ee76f2042fe07ad5cf8edeb5065bc0aba320 commit 3e01ee76f2042fe07ad5cf8edeb5065bc0aba320 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2021-12-20 17:57:34 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2021-12-20 17:59:01 +0000 lorder: add note that it is no longer required Use of lorder(1) is not required by contemporary linkers. The GNU coreutils manual[1] has a good description of the use of lorder and tsort: This whole procedure has been obsolete since about 1980, because Unix archives now contain a symbol table (traditionally built by ranlib, now generally built by ar itself), and the Unix linker uses the symbol table to effectively make multiple passes over an archive file. See 0e1e341b486c for some more details. [1] https://www.gnu.org/software/coreutils/manual/html_node/tsort-background.html PR: 259254 [exp-run] MFC after: 2 weeks Sponsored by: The FreeBSD Foundation usr.bin/lorder/lorder.1 | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
CC marius@ for cdrdao, fullermd@over-yonder.net for libcidr, and uqs@ for sysutils/symon
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0a6f1823129e631da6f11368836f8b2fd5483096 commit 0a6f1823129e631da6f11368836f8b2fd5483096 Author: Marius Strobl <marius@FreeBSD.org> AuthorDate: 2021-12-20 20:36:30 +0000 Commit: Marius Strobl <marius@FreeBSD.org> CommitDate: 2021-12-20 20:52:44 +0000 sysutils/cdrdao: drop use of lorder(1) While at it, switch pkg-plist to @postunexec and remove remnants of the gcdmaster slave missed in db5b4a8694f902fef50919c2744ee2ee31fcd89b. PR: 259254 sysutils/cdrdao/Makefile | 15 +++++------- sysutils/cdrdao/files/patch-dao_cdrdao.man | 27 +++++++++++++++------- .../files/patch-scsilib_RULES_i386-freebsd-cc.rul | 8 ++++--- sysutils/cdrdao/pkg-plist | 2 +- 4 files changed, 31 insertions(+), 21 deletions(-)
I'm done here.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=128d3b57be1f406be9656f40152c2290494da1b9 commit 128d3b57be1f406be9656f40152c2290494da1b9 Author: Ulrich Spörlein <uqs@FreeBSD.org> AuthorDate: 2021-12-27 09:24:00 +0000 Commit: Ulrich Spörlein <uqs@FreeBSD.org> CommitDate: 2021-12-27 09:27:43 +0000 sysutils/symon: Update to 2.88 This version only changes some Linux specific area. Get rid of the calls to lorder and tsort though, as these will go away. PR: 259254 sysutils/symon/Makefile | 6 +++--- sysutils/symon/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=b498248f7a705d45cab6ac14ec67bb408621aabf commit b498248f7a705d45cab6ac14ec67bb408621aabf Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2021-12-20 17:57:34 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2022-01-03 01:17:00 +0000 lorder: add note that it is no longer required Use of lorder(1) is not required by contemporary linkers. The GNU coreutils manual[1] has a good description of the use of lorder and tsort: This whole procedure has been obsolete since about 1980, because Unix archives now contain a symbol table (traditionally built by ranlib, now generally built by ar itself), and the Unix linker uses the symbol table to effectively make multiple passes over an archive file. See 0e1e341b486c for some more details. [1] https://www.gnu.org/software/coreutils/manual/html_node/tsort-background.html PR: 259254 [exp-run] MFC after: 2 weeks Sponsored by: The FreeBSD Foundation (cherry picked from commit 3e01ee76f2042fe07ad5cf8edeb5065bc0aba320) usr.bin/lorder/lorder.1 | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=811f36c660a2d40b57bfbf8a9728866d83130d12 commit 811f36c660a2d40b57bfbf8a9728866d83130d12 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2021-12-20 17:57:34 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2022-01-03 01:17:34 +0000 lorder: add note that it is no longer required Use of lorder(1) is not required by contemporary linkers. The GNU coreutils manual[1] has a good description of the use of lorder and tsort: This whole procedure has been obsolete since about 1980, because Unix archives now contain a symbol table (traditionally built by ranlib, now generally built by ar itself), and the Unix linker uses the symbol table to effectively make multiple passes over an archive file. See 0e1e341b486c for some more details. [1] https://www.gnu.org/software/coreutils/manual/html_node/tsort-background.html PR: 259254 [exp-run] MFC after: 2 weeks Sponsored by: The FreeBSD Foundation (cherry picked from commit 3e01ee76f2042fe07ad5cf8edeb5065bc0aba320) usr.bin/lorder/lorder.1 | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=68a930d8ee35dd6ecc16254667a07e5be0a6f841 commit 68a930d8ee35dd6ecc16254667a07e5be0a6f841 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2023-03-21 14:20:42 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2023-03-21 14:20:42 +0000 lorder: add deprecation notice lorder has not been used by the base system since 0e1e341b486c and hasn't really been necessary for a very long time. PR: 259254 [exp-run] Reviewed by: arichardson (earlier) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D30080 usr.bin/lorder/lorder.1 | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=e26552c0d882c8c9fedb7c2c80ccb8a5faa73607 commit e26552c0d882c8c9fedb7c2c80ccb8a5faa73607 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2023-03-21 14:20:42 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2023-03-23 12:41:35 +0000 lorder: add deprecation notice lorder has not been used by the base system since 0e1e341b486c and hasn't really been necessary for a very long time. PR: 259254 [exp-run] Reviewed by: arichardson (earlier) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D30080 (cherry picked from commit 68a930d8ee35dd6ecc16254667a07e5be0a6f841) usr.bin/lorder/lorder.1 | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=c68dc69680d3a4bfe97291df6d72262008f20fa0 commit c68dc69680d3a4bfe97291df6d72262008f20fa0 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2023-03-21 14:20:42 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2023-03-23 12:49:43 +0000 lorder: add deprecation notice lorder has not been used by the base system since 0e1e341b486c and hasn't really been necessary for a very long time. PR: 259254 [exp-run] Reviewed by: arichardson (earlier) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D30080 (cherry picked from commit 68a930d8ee35dd6ecc16254667a07e5be0a6f841) (cherry picked from commit e26552c0d882c8c9fedb7c2c80ccb8a5faa73607) usr.bin/lorder/lorder.1 | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a0cdafda51c9a9f0b843a55bc6be43185fd53731 commit a0cdafda51c9a9f0b843a55bc6be43185fd53731 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2021-10-21 18:17:31 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2023-04-12 17:56:22 +0000 converters/iconv: drop use of lorder(1) lorder is obsolete and may be removed from the base system in the future. PR: 259254 [exp-run] Reviewed by: jrm Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D32593 converters/iconv/Makefile | 2 +- converters/iconv/files/patch-ces__Makefile | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-)