Bug 259511 - Mk/bsd.port.mk: Fix comments about PKGVERSION
Summary: Mk/bsd.port.mk: Fix comments about PKGVERSION
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-28 17:10 UTC by Yasuhiro Kimura
Modified: 2021-11-25 00:50 UTC (History)
1 user (show)

See Also:

Attachments
Patch file (1.72 KB, patch)
2021-10-28 17:10 UTC, Yasuhiro Kimura 		no flags Details | Diff
Updated patch file (1019 bytes, patch)
2021-11-08 16:08 UTC, Yasuhiro Kimura 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2021-10-28 17:10:17 UTC 
Created attachment 229102 [details]
Patch file

* The value of PKGNAME described in comment is different from real one. So fix it. Additionally add brief explanation what the variable means.
* The value of PKGVERSION described in comment is also different from real one. And it is difficult to explain the latter briefly. So replace it with brief explanation what the variable means.
Comment 1 Yasuhiro Kimura freebsd_committer freebsd_triage 2021-11-08 16:08:04 UTC 
Created attachment 229365 [details]
Updated patch file

Comment about PKGNAME is fixed with ports 7f5e93027a72. So update patch so it only fixes comment about PKGVERSION.
Comment 2 Baptiste Daroussin freebsd_committer freebsd_triage 2021-11-19 20:44:00 UTC 
Please commit your patch, approved by portmgr (bapt)
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-11-25 00:46:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=edabbf820119e46d1fe8fc3a567bae20debf4625

commit edabbf820119e46d1fe8fc3a567bae20debf4625
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2021-10-28 16:40:55 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-11-25 00:45:30 +0000

    Mk/bsd.port.mk: Fix comments about PKGVERSION

    * The value of PKGVERSION described in comment is different from real
      one. And it is difficult to explain it briefly. So replace it with
      brief explanation what the variable means.

    PR:             259511
    Approved by:    portmgr (bapt)

 Mk/bsd.port.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)