Bug 259556 - devel/autoconf: optionalize INFO
Summary: devel/autoconf: optionalize INFO
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tijl Coosemans
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-10-30 17:33 UTC by Val Packett
Modified: 2022-05-27 10:16 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (tijl)


Attachments
0001-devel-autoconf-optionalize-INFO.patch (3.33 KB, patch)
2021-10-30 17:33 UTC, Val Packett
no flags Details | Diff
0001-devel-autoconf-optionalize-INFO.patch (3.36 KB, patch)
2021-10-31 10:56 UTC, Val Packett
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2021-10-30 17:33:52 UTC
Created attachment 229152 [details]
0001-devel-autoconf-optionalize-INFO.patch

makeinfo can be an annoying/unwanted build dependency. info pages aren't popular in the BSD world anyway. Maybe let's make them optional here, and disable by default even, like in this patch?
Comment 1 Val Packett 2021-10-31 10:56:38 UTC
Created attachment 229170 [details]
0001-devel-autoconf-optionalize-INFO.patch
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2021-11-01 00:45:14 UTC
(In reply to Greg V from comment #0)
> makeinfo can be an annoying/unwanted build dependency
What exactly makes it annoying?  It takes two minutes to build even on my ten year old Intel E5500 CPU, and resulting package weighs roughly one megabyte.

Also, `print/texinfo' is fairly low-volatile port, anyone who builds software from ports likely has it installed already, and those who use binary packages are not concerned with build dependencies.  I don't see how this warrants complicating all the ports which install info files with additional Makefile logic and patches.
Comment 3 Val Packett 2021-11-01 12:20:41 UTC
(In reply to Alexey Dokuchaev from comment #2)

The dependencies are annoying when trying to build a minimal system. texinfo depends on a bunch of Perl stuff (granted, autoconf itself needs perl) including p5-Locale-libintl which needs iconv:translit i.e. GNU libiconv.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-05-27 09:56:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ec2102597a4ed2e4c9075d3c4b6399e13c0956c2

commit ec2102597a4ed2e4c9075d3c4b6399e13c0956c2
Author:     Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2022-05-02 08:55:28 +0000
Commit:     Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2022-05-27 09:51:04 +0000

    devel/autoconf*: restructure to prepare for 2.71

    - Rename autoconf 2.13 port directory, package, and command all to
      autoconf2.13 just like ports like perl and python.
    - Let USES=autoreconf run gtkdocize if necessary.
    - Rewrite autoconf-wrapper and rename it autoconf-switch to reflect
      better what it does.
    - Delete patch-bison.  It has been reverted upstream.
    - Add a patch to let autoreconf set the AUTOCONF environment variable
      so subprocesses like automake use the correct version.
    - Make building of info files optional.
    - Address portlint, portclippy, portfmt issues in devel/autoconf*.

    PR:             259556, 263970

 MOVED                                              |   2 +
 Mk/Uses/autoreconf.mk                              |  30 ++++-
 databases/jlog/Makefile                            |   4 +-
 devel/Makefile                                     |   4 +-
 devel/autoconf-switch/Makefile (new)               |  22 ++++
 devel/autoconf-switch/files/autoconf (new)         |   4 +
 devel/autoconf-switch/pkg-descr (new)              |   4 +
 devel/autoconf-switch/pkg-plist (new)              |   7 ++
 devel/autoconf-wrapper/Makefile (gone)             |  43 --------
 .../files/autotools-wrapper.sh (gone)              |  89 ---------------
 devel/autoconf-wrapper/pkg-descr (gone)            |   3 -
 devel/autoconf/Makefile                            |  97 ++++++++++------
 devel/autoconf/files/patch-bin_autoreconf.in (new) |  10 ++
 ...patch-bin-autoscan.in => patch-bin_autoscan.in} |   0
 devel/autoconf/files/patch-bison (gone)            |  53 ---------
 ...patch-doc-Makefile.in => patch-doc_Makefile.in} |   9 +-
 devel/autoconf/files/patch-doc_autoconf.texi       |  47 ++------
 devel/autoconf/files/patch-texinfo (gone)          |  12 --
 devel/autoconf/pkg-descr                           |   6 +-
 devel/autoconf/pkg-plist                           | 122 ++++++++++-----------
 devel/autoconf2.13/Makefile (new)                  |  66 +++++++++++
 devel/{autoconf213 => autoconf2.13}/distinfo       |   1 +
 .../files/patch-acspecific.m4                      |   6 +-
 .../files/patch-autoconf.sh                        |  27 ++++-
 devel/autoconf2.13/files/patch-autoconf.texi (new) |  17 +++
 .../files/patch-autoheader.sh}                     |   6 +-
 .../files/patch-autoupdate.sh                      |   8 +-
 devel/{autoconf213 => autoconf2.13}/pkg-descr      |   9 +-
 devel/autoconf2.13/pkg-plist (new)                 |  19 ++++
 devel/autoconf213/Makefile (gone)                  |  45 --------
 devel/autoconf213/files/patch-Makefile.in (gone)   |  36 ------
 devel/autoconf213/files/patch-autoconf.texi (gone) |  24 ----
 devel/autoconf213/pkg-plist (gone)                 |  22 ----
 devel/autotools/Makefile                           |   4 +-
 devel/util-linux/files/patch-configure.ac (new)    |  12 ++
 lang/spidermonkey78/Makefile                       |   2 +-
 lang/spidermonkey91/Makefile                       |   4 +-
 mail/thunderbird/Makefile                          |   8 +-
 sysutils/consolekit2/files/patch-configure.ac      |  16 ++-
 www/firefox-esr/Makefile                           |   6 +-
 www/firefox/Makefile                               |   6 +-
 x11-fm/librfm/files/patch-configure.ac (new)       |  10 ++
 x11/keybinder-gtk3/Makefile                        |   2 +
 43 files changed, 405 insertions(+), 519 deletions(-)