Comment 1 Kubilay Kocak 2021-11-02 01:11:32 UTC

^Triage: Please confirm this change passes QA (portlint, poudriere at least)

For details and instructions, see:

https://docs.freebsd.org/en/books/porters-handbook/#testing

Additional review items:

- Upstream supports and tests for 2/3 up to 3.9. The port declares 3.6+ incorrectly. Please update the USES=python:<version-spec> to correctly match support (Note: Additional dependency on ["typing; python_version < '3.5'"])

- Upstream declares mock as a dependency for tests, but the port does not declare a TEST_DEPENDS. Do the tests pass without mock? 

- Add "-o addopts=" the pytest invocation, this is good for overriding unnecessary and additional upstream development dependencies such as coverage, codecov, pylint, etc

Comment 2 Kubilay Kocak 2021-11-03 01:00:27 UTC

1.3.1 landed in bug 259307

Hello @koobs,
I am working on making requested changes to the patch, but I have a question:
 * you said "Note: Additional dependency on ["typing; python_version < '3.5'"]": does this change make sense given python 2.7 has been discontinued for a while now and FreebsBSD ports tree has Python3 >= 3.6?

Thank you

Created attachment 229242 [details]
trivial update of distinfo and port version

Created attachment 229243 [details]
trivial update of distinfo and port version

Comment 6 Kubilay Kocak 2021-11-04 05:00:24 UTC

(In reply to Alessandro Sagratini from comment #3)

Python ports are declarative, not imperative, in that they declare what versions the package supports, rather than specifying or choosing a version.

Whether any Python port language versions exists or doesn't exist in the tree at any time, which changes over time, is not consequential.

It is up to python.mk to determine the python version that will be used, based on: 

1) the versions the port supports, and
2  what is available in the tree (on the user system), and
3) considering the version the user wants (DEFAULT_VERSIONS), and
4) what the current 'default version' version order is in python.mk

tldr; specify the USES=python=<version-spec> as closely matching what upstream  upstream defines and/or tests against (sometimes they're not super precise or up to date). 

Note: there's certain things our version-spec format doesnt support, such as "!=X.Y" and multiple non-consecutive versions (like X.X,XZ) which are rarely needed.

Comment 7 Yasuhiro Kimura 2021-11-04 05:09:54 UTC

@koobs Why did you request maintainer feedback to me? I'm not maintainer of this port.

Comment 8 Kubilay Kocak 2021-11-04 05:24:40 UTC

(In reply to Yasuhiro Kimura from comment #7)

We don't have non-maintainer feedback flags (yet) to request feedback or loop in arbitrary people (without CC'ing them).

I added you for feedback given ports ae9fd746568e (1.3.1 commit of this port) which I believe existed as a issue at the same time this did, so I added that to Depends On here (as a reference to it: bug 259307) so you were aware of it, wanted to commit it, or otherwise.

Comment 9 Yasuhiro Kimura 2021-11-04 05:59:14 UTC

(In reply to Kubilay Kocak from comment #8)

OK, I understand your intention now. However, please use comment rather than maintainer-feedback flag next time you face same situation. It's not intuitive enough to use the flag in this case.

Created attachment 229260 [details]
version update plus various fixes

patch updated @koobs, let me know if you have any further feedback on it

Comment 12 Kubilay Kocak 2021-11-05 00:24:02 UTC

MFH: No (port not in quarterly)

I'm bumping this bug to understand if you need anything else from me or we just need to wait for someone to review it.

Thank you,
Alessandro

Hi folks,
any luck with this? Anything else you need from me?

Thank you

Hi folks,
any luck with this? Anything else you need from me?

Thank you

Comment 16 Yasuhiro Kimura 2021-12-01 23:40:12 UTC

Take.

Comment 17 commit-hook 2021-12-01 23:50:21 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b0a0ddad272a2804bc73068635128f15dedecec8

commit b0a0ddad272a2804bc73068635128f15dedecec8
Author:     Alessandro Sagratini <ale_sagra@hotmail.com>
AuthorDate: 2021-10-31 17:14:03 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-12-01 23:49:13 +0000

    devel/py-circuitbreaker: Update to 1.3.2

    * Update range of Python
    * Add missing devel/py-mock to TEST_DEPENDS
    * Switch to DISTVERSION

    Changes:        https://github.com/fabfuel/circuitbreaker/commits/1.3.2
    PR:             259579

 devel/py-circuitbreaker/Makefile | 9 +++++----
 devel/py-circuitbreaker/distinfo | 6 +++---
 2 files changed, 8 insertions(+), 7 deletions(-)

Comment 18 Yasuhiro Kimura 2021-12-01 23:54:52 UTC

Committed with some refinements. Thanks!