Bug 259640 - snd_hda(4): Fix sound output in Lenovo Ideapad 330-15 and ThinkPad X230
Summary: snd_hda(4): Fix sound output in Lenovo Ideapad 330-15 and ThinkPad X230
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 13.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: easy, feature, needs-qa
Depends on:
Blocks:
 
Reported: 2021-11-04 09:05 UTC by Dmitry Lukhtionov
Modified: 2024-03-03 13:19 UTC (History)
6 users (show)

See Also:
koobs: mfc-stable13?
koobs: mfc-stable12?

Attachments
patch (2.71 KB, patch)
2021-11-04 09:05 UTC, Dmitry Lukhtionov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Lukhtionov 2021-11-04 09:05:36 UTC 
Created attachment 229263 [details]
patch

Fix sound output in Lenovo Ideapad 330-15 and Lenovo ThinkPad X230
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-11-05 00:37:56 UTC 
Thank you for the report and patch Dmitry
Comment 2 Christos Margiolis freebsd_committer freebsd_triage 2024-02-08 13:21:46 UTC 
Hello Dmitry,

Thank you for the patch. Can you make sure it still works without problems? If it does, I will make sure to commit it ASAP.
Comment 3 Dmitry Lukhtionov 2024-02-09 14:04:15 UTC 
Hello Christos,

Thanks for answer

The patch was tested on Lenovo Ideapad 330-15 and ThinkPad X230 and worked fine
Comment 4 Christos Margiolis freebsd_committer freebsd_triage 2024-02-09 17:42:53 UTC 
(In reply to Dmitry Lukhtionov from comment #3)
I submitted a patch for review. It needed some minor changes since your original patch is quite old.

https://reviews.freebsd.org/D43804

Could you please apply it and test it one more time to make sure? Thanks.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-02-18 17:08:25 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=5968e477a560406c480d78ebe438a04f57121119

commit 5968e477a560406c480d78ebe438a04f57121119
Author:     Dmitry Lukhtionov <dmitryluhtionov@gmail.com>
AuthorDate: 2024-02-18 17:07:39 +0000
Commit:     Christos Margiolis <christos@FreeBSD.org>
CommitDate: 2024-02-18 17:07:39 +0000

    snd_hda: Add patches for the Lenovo Ideapad 330-15 and ThinkPad X230

    PR:             259640
    MFC after:      2 weeks
    Reviewed by:    delphij, markj
    Differential Revision:  https://reviews.freebsd.org/D43804

 sys/dev/sound/pci/hda/hdaa_patches.c | 20 ++++++++++++++++++++
 sys/dev/sound/pci/hda/hdac.h         |  2 ++
 sys/dev/sound/pci/hda/hdacc.c        |  1 +
 3 files changed, 23 insertions(+)
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-03-03 13:19:06 UTC 
A commit in branch stable/14 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=2d694deca985517c3eab9d51bf4c7cf20dd6bc03

commit 2d694deca985517c3eab9d51bf4c7cf20dd6bc03
Author:     Dmitry Lukhtionov <dmitryluhtionov@gmail.com>
AuthorDate: 2024-02-18 17:07:39 +0000
Commit:     Christos Margiolis <christos@FreeBSD.org>
CommitDate: 2024-03-03 13:18:02 +0000

    snd_hda: Add patches for the Lenovo Ideapad 330-15 and ThinkPad X230

    PR:             259640
    MFC after:      2 weeks
    Reviewed by:    delphij, markj
    Differential Revision:  https://reviews.freebsd.org/D43804

    (cherry picked from commit 5968e477a560406c480d78ebe438a04f57121119)

 sys/dev/sound/pci/hda/hdaa_patches.c | 20 ++++++++++++++++++++
 sys/dev/sound/pci/hda/hdac.h         |  2 ++
 sys/dev/sound/pci/hda/hdacc.c        |  1 +
 3 files changed, 23 insertions(+)