Bug 259687 - [NEW PORT] net-im/purple-googlechat: Google Chat Plugin for libpurple
Summary: [NEW PORT] net-im/purple-googlechat: Google Chat Plugin for libpurple
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: https://github.com/EionRobb/purple-go...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-06 21:12 UTC by Jose G. Juanino
Modified: 2021-12-08 10:51 UTC (History)
1 user (show)

See Also:

Attachments
net-im/purple-googlechat new port (2.34 KB, patch)
2021-11-06 21:12 UTC, Jose G. Juanino 		no flags Details | Diff
cosmetic changes to the previous attach (2.26 KB, patch)
2021-11-20 17:49 UTC, Jose G. Juanino 		jjuanino: maintainer-approval+
Details | Diff
poudriere build log (45.66 KB, text/plain)
2021-11-20 17:50 UTC, Jose G. Juanino 		jjuanino: maintainer-approval+
Details
fixes DISTVERSION (2.21 KB, patch)
2021-11-20 21:59 UTC, Jose G. Juanino 		jjuanino: maintainer-approval+
Details | Diff
new poudriere build (45.66 KB, text/plain)
2021-11-20 22:01 UTC, Jose G. Juanino 		jjuanino: maintainer-approval+
Details
remove NLS stuff (2.17 KB, patch)
2021-11-21 09:50 UTC, Jose G. Juanino 		jjuanino: maintainer-approval+
Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jose G. Juanino 2021-11-06 21:12:15 UTC 
Created attachment 229336 [details]
net-im/purple-googlechat new port

New port for purple-googlechat pidgin plugin

https://github.com/EionRobb/purple-googlechat

A replacement prpl for Google Chat in Pidgin/libpurple to support the
proprietary protocol that Google uses for its "Google Chat" service.
Comment 1 Jose G. Juanino 2021-11-20 17:49:31 UTC 
Created attachment 229617 [details]
cosmetic changes to the previous attach

Upload a new attachment with only cosmetic changes, as order of variables and strip of "Created by" first line.
Comment 2 Jose G. Juanino 2021-11-20 17:50:39 UTC 
Created attachment 229618 [details]
poudriere build log

Poudriere build log
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-11-20 20:17:02 UTC 
Looks good overall, needs a few tweaks if you look at "Example 18. Using USE_GITHUB When Upstream Does Not Use Versions" in Porters Handbook
https://docs.freebsd.org/en/books/porters-handbook/book/

PORTVERSION --> DISTVERSION
Also not the (g) before the date

pkg-desc
"[excerpt from purple-googlechat web site]" - Why is this here?
prpl --> ? (I'd suggest that you rephrase that part)

Best regards,
Daniel
Comment 4 Jose G. Juanino 2021-11-20 21:59:40 UTC 
Created attachment 229621 [details]
fixes DISTVERSION
Comment 5 Jose G. Juanino 2021-11-20 22:01:00 UTC 
Created attachment 229622 [details]
new poudriere build
Comment 6 Jose G. Juanino 2021-11-20 22:04:34 UTC 
(In reply to Daniel Engberg from comment #3)
Hi Daniel, I have fixed the patch with your suggestions. But I do not understand what you say about

> Also not the (g) before the date

Indeed, the example 18 you are mentioning says the opposite: the DISTVERSION must be prefixed with "g". Am I misunderstanding something?

A new poudriere build log has been uploaded also.

Regards
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2021-11-20 23:52:09 UTC 
Thanks! You don't need to upload a build log each time just state that you've tested it and target platform + FreeBSD vesion.
How does the NLS logic work? I don't see anything obvious mentioned in the Makefile (upstream) but I didn't spend time looking carefully at it.
Comment 8 Jose G. Juanino 2021-11-21 09:50:24 UTC 
Created attachment 229630 [details]
remove NLS stuff
Comment 9 Jose G. Juanino 2021-11-21 09:52:57 UTC 
(In reply to Daniel Engberg from comment #7)

Hi Daniel, thank you for your work and your suggestions.

Sorry for the unnecessary upload of poudriere logs, I will not do it anymore.

About the NLS setting: is useless, I have removed it from the Makefile. I have submitted a new patch version.

Regards
Comment 10 commit-hook freebsd_committer freebsd_triage 2021-12-08 10:50:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c6af9d33ffc7c77184a2591db7b4be5a7663a151

commit c6af9d33ffc7c77184a2591db7b4be5a7663a151
Author:     Jose G. Juanino <jjuanino@gmail.com>
AuthorDate: 2021-12-08 10:44:19 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2021-12-08 10:48:52 +0000

    net-im/purple-googlechat: New port: Google Chat plugin for libpurple

    WWW: https://github.com/EionRobb/purple-googlechat/

    PR:             259687
    Approved by:    mentors (implicit)

 net-im/Makefile                            |  1 +
 net-im/purple-googlechat/Makefile (new)    | 29 +++++++++++++++++++++++++++++
 net-im/purple-googlechat/distinfo (new)    |  3 +++
 net-im/purple-googlechat/pkg-descr (new)   |  4 ++++
 net-im/purple-googlechat/pkg-message (new) |  8 ++++++++
 5 files changed, 45 insertions(+)
Comment 11 Daniel Engberg freebsd_committer freebsd_triage 2021-12-08 10:51:31 UTC 
Committed, thanks!