Bug 259979 - irc/py-limnoria: 2019.09.08 doesn't run with Python 3.10
Summary: irc/py-limnoria: 2019.09.08 doesn't run with Python 3.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kai Knoblich
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2021-11-21 23:09 UTC by Simeon Simeonov
Modified: 2021-12-01 22:39 UTC (History)
2 users (show)

See Also:
kai: merge-quarterly+

Attachments
Upgrading to limnoria-2021.10.09 (10.51 KB, patch)
2021-11-21 23:09 UTC, Simeon Simeonov 		no flags Details | Diff
Initial commit (737 bytes, patch)
2021-11-22 04:19 UTC, Simeon Simeonov 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simeon Simeonov 2021-11-21 23:09:31 UTC 
Created attachment 229649 [details]
Upgrading to limnoria-2021.10.09

irc/py-limnoria-2019.09.08 fails to run on Python 3.10 since 
collections.MutableMapping is moved to collections.abc.MutableMapping.

[sgs@SagaBOX ~]$ supybot -h
Traceback (most recent call last):
  File "/usr/local/bin/supybot", line 37, in <module>
    import supybot
  File "/usr/local/lib/python3.10/site-packages/supybot/__init__.py", line 37, in <module>
    from . import utils
  File "/usr/local/lib/python3.10/site-packages/supybot/utils/__init__.py", line 64, in <module>
    from .gen import *
  File "/usr/local/lib/python3.10/site-packages/supybot/utils/gen.py", line 44, in <module>
    from .str import format
  File "/usr/local/lib/python3.10/site-packages/supybot/utils/str.py", line 44, in <module>
    from .structures import TwoWayDictionary
  File "/usr/local/lib/python3.10/site-packages/supybot/utils/structures.py", line 430, in <module>
    class CacheDict(collections.MutableMapping):
AttributeError: module 'collections' has no attribute 'MutableMapping'


Upgrading to a newer version seems to fix that issue.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-11-21 23:22:31 UTC 
First commit should be fixing USES=python:<version-spec> to -3.9 and merged to quarterly, prior to version update

Thank you for the report and patch Simeon
Comment 2 Simeon Simeonov 2021-11-22 04:19:24 UTC 
Created attachment 229651 [details]
Initial commit

Initial commit
Comment 3 Simeon Simeonov 2021-11-28 14:41:44 UTC 
poudriere testport passes for Python 3.8 and 3.9 on amd64
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2021-11-30 01:30:32 UTC 
Thank you for testing Simeon!
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-12-01 09:14:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=44058fa9c71b7d9243a208d2d3ec8b8073686d57

commit 44058fa9c71b7d9243a208d2d3ec8b8073686d57
Author:     Simeon Simeonov <sgs@pichove.org>
AuthorDate: 2021-12-01 09:02:37 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2021-12-01 09:02:37 +0000

    irc/py-limnoria: Mark as not compatible with Python 3.10+

    Since Python 3.10 the method "collections.MutableMapping" has been
    renamed to "collections.abc.MutableMapping" which leads to run time
    errors:

    [..]
        class CacheDict(collections.MutableMapping):
    AttributeError: module 'collections' has no attribute 'MutableMapping'
    [..]

    PR:             259979
    Reviewed by:    koobs (maintainer)
    Approved by:    portmgr (blanket)
    MFH:            2021Q4

 irc/py-limnoria/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-12-01 09:25:55 UTC 
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fb9df1c7afb68cfe119626eb5961cc2a1a4ffbd1

commit fb9df1c7afb68cfe119626eb5961cc2a1a4ffbd1
Author:     Simeon Simeonov <sgs@pichove.org>
AuthorDate: 2021-12-01 09:02:37 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2021-12-01 09:20:20 +0000

    irc/py-limnoria: Mark as not compatible with Python 3.10+

    Since Python 3.10 the method "collections.MutableMapping" has been
    renamed to "collections.abc.MutableMapping" which leads to run time
    errors:

    [..]
        class CacheDict(collections.MutableMapping):
    AttributeError: module 'collections' has no attribute 'MutableMapping'
    [..]

    PR:             259979
    Reviewed by:    koobs (maintainer)
    Approved by:    portmgr (blanket)
    MFH:            2021Q4

    (cherry picked from commit 44058fa9c71b7d9243a208d2d3ec8b8073686d57)

 irc/py-limnoria/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 Kai Knoblich freebsd_committer freebsd_triage 2021-12-01 09:28:17 UTC 
Committed to head and MFH'ed to the 2021Q4 branch, thanks for the patch!
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2021-12-01 22:39:37 UTC 
(In reply to commit-hook from comment #6)

Thank you!