Created attachment 229663 [details] fix to unBREAK the build newer versions of databases/sqlite3 dependency require it to be built not just patched.
^Triage: - maintainer-feedback flag (+) not required unless requested (?) first - [tags] in issue Titles are deprecated
Created attachment 229669 [details] BUILD_DEPENDS passes Lua FLAVOR to sqlite3 build and fails moved forced building of sqlite3 to the pre-configure target where the Lua FLAVOR can be stripped from the ENVironment. Otherwise portmaster upgrading fails.
(In reply to yds from comment #2) > moved forced building of sqlite3 to the pre-configure target where the Lua > FLAVOR can be stripped from the ENVironment. Otherwise portmaster upgrading > fails. Hmm, I cannot reproduce it with portmaster 3.21. Can you show me how to trigger this particular error? The first patch is correct since we had switched away from using amalgamated SQLite sources.
(In reply to Alexey Dokuchaev from comment #3) right.. I cannot reproduce the need for stripping the FLAVOR hack I introduced with the second patch.. the first patch is the correct one to use.. tested the first patch with the latest portmaster, while at it upgrading to sqlite3-3.39.0 and it all built and installed without error.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a649f0aae00f624c3c0d8f018e86acc33688d1fb commit a649f0aae00f624c3c0d8f018e86acc33688d1fb Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2022-07-07 19:13:30 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2022-07-07 19:13:30 +0000 databases/lua-lsqlite3: unbreak the build against non-amalgamated SQLite - Change the :target in SQLite dependency to `build' so that files which are copied during `pre-configure' stage would be generated; - Don't explicitly list supported Lua versions in the COMMENT and define options after other declarative knobs and before targets; - Switch to the new upstream distfile (version remained the same) as the previous one is no longer fetchable. Looking at the changes, they span the period from 2018-07-01 to 2021-09-07 and look legit. Also, the test suite had been amended; it would be hooked in another commit. PR: 259991 databases/lua-lsqlite3/Makefile | 12 +++++------- databases/lua-lsqlite3/distinfo | 6 +++--- 2 files changed, 8 insertions(+), 10 deletions(-)