Bug 260054 - net/py-ldap: Don't require OpenLDAP 2.4 and fix build for OpenLDAP 2.5+
Summary: net/py-ldap: Don't require OpenLDAP 2.4 and fix build for OpenLDAP 2.5+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks: 258297
  Show dependency treegraph
 
Reported: 2021-11-26 02:51 UTC by Xin LI
Modified: 2021-12-02 10:36 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rm)


Attachments
Proposed patch (1.46 KB, patch)
2021-11-26 02:51 UTC, Xin LI
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xin LI freebsd_committer freebsd_triage 2021-11-26 02:51:55 UTC
Created attachment 229734 [details]
Proposed patch

OpenLDAP 2.3 is no longer available from the ports tree, and net/py-ldap should no longer require OpenLDAP 2.4.

While there, also fix build when building with OpenLDAP 2.5 by replacing libldap_r with libldap (we have recently merged libldap_r with libldap recently for OpenLDAP 2.4.x series, so this should be a no-op if user is using OpenLDAP 2.4).
Comment 1 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2021-12-02 09:42:23 UTC
Looking at it
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-12-02 10:30:11 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7becd3b8b86d998d5c1b4aa3125522d30b435d79

commit 7becd3b8b86d998d5c1b4aa3125522d30b435d79
Author:     Ruslan Makhmatkhanov <rm@FreeBSD.org>
AuthorDate: 2021-12-02 10:27:12 +0000
Commit:     Ruslan Makhmatkhanov <rm@FreeBSD.org>
CommitDate: 2021-12-02 10:27:12 +0000

    net/py-ldap: do not imply openldap 2.4

    - add patch to fix build OpenLDAP 2.5
    - do not imply 2.4 version

    PR:             260054
    Reported by:    delphij

 net/py-ldap/Makefile                    |  1 -
 net/py-ldap/files/patch-setup.cfg (new) | 11 +++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
Comment 3 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2021-12-02 10:35:09 UTC
Committed, thank you!