Bug 260184 - devel/libowfat: Fails to link: ld: error: duplicate symbol: first_deferred
Summary: devel/libowfat: Fails to link: ld: error: duplicate symbol: first_deferred
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks: 253763
  Show dependency tree / graph
 
Reported: 2021-12-03 04:00 UTC by Marco Steinbach
Modified: 2023-02-20 18:08 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (lx)
koobs: merge-quarterly?

Attachments
git diff (850 bytes, patch)
2021-12-03 04:00 UTC, Marco Steinbach 		no flags Details | Diff
poudriere and portlint output (112.47 KB, text/plain)
2021-12-03 04:01 UTC, Marco Steinbach 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Steinbach 2021-12-03 04:00:33 UTC 
Created attachment 229854 [details]
git diff

Hi there.

It would seem, that as a result of defaulting to -fno_common instead of -fcommon, ports depending on devel/libowfat break.

One example is www/gatling:

ld: error: duplicate symbol: first_deferred
>>> defined at io_close.c
>>>            io_close.o:(first_deferred) in archive /usr/local/lib/libowfat.a
>>> defined at io_fd.c
>>>            io_fd.o:(.bss+0xD8) in archive /usr/local/lib/libowfat.a

This small patch, the idea for which I have blatantly stolen from https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/libowfat/files/libowfat-0.32-gcc10.patch tries to fix that.

- Bump PORTREVISION
- Add new patchfile for io_internal.h
Comment 1 Marco Steinbach 2021-12-03 04:01:41 UTC 
Created attachment 229855 [details]
poudriere and portlint output
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2022-04-26 09:41:47 UTC 
Maintainer reset.
Comment 3 Li-Wen Hsu freebsd_committer freebsd_triage 2023-02-20 17:51:15 UTC 
devel/libowfat builds fine now.
Comment 4 Li-Wen Hsu freebsd_committer freebsd_triage 2023-02-20 17:58:05 UTC 
The patch is for fixing the depending ports.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-02-20 18:08:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c983a807cafca5e32628dfa1b5808207b0292b91

commit c983a807cafca5e32628dfa1b5808207b0292b91
Author:     Marco Steinbach <coco@executive-computing.de>
AuthorDate: 2023-02-20 18:05:18 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2023-02-20 18:05:18 +0000

    devel/libowfat: Fix depending ports build with -fno-common

    This small patch, the idea for which I have blatantly stolen from
    https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/libowfat/files/libowfat-0.32-gcc10.patch
    tries to fix that.

    PR:             260184

 devel/libowfat/Makefile                        |  1 +
 devel/libowfat/files/patch-io_internal.h (new) | 11 +++++++++++
 2 files changed, 12 insertions(+)