Bug 260298 - astro/marble: Fails to configure: missing dependency on Qt testlib
Summary: astro/marble: Fails to configure: missing dependency on Qt testlib
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-kde (group)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-12-09 22:32 UTC by Eric Camachat
Modified: 2021-12-10 00:14 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (kde)
koobs: merge-quarterly?


Attachments
fix configure failure (964 bytes, patch)
2021-12-09 22:32 UTC, Eric Camachat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Camachat 2021-12-09 22:32:08 UTC
Created attachment 230003 [details]
fix configure failure

Fix configure error:
===>  Configuring for marble-21.08.3_1
===>  Performing out-of-source build
/bin/mkdir -p /wrkdirs/usr/ports/astro/marble/work/.build
-- The C compiler identification is Clang 11.0.1
-- The CXX compiler identification is Clang 11.0.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Could NOT find Protobuf (missing: Protobuf_LIBRARIES Protobuf_INCLUDE_DIR)
CMake Error at /usr/local/lib/cmake/Qt5/Qt5Config.cmake:28 (find_package):
  Could not find a package configuration file provided by "Qt5Test" with any
  of the following names:

    Qt5TestConfig.cmake
    qt5test-config.cmake

  Add the installation prefix of "Qt5Test" to CMAKE_PREFIX_PATH or set
  "Qt5Test_DIR" to a directory containing one of the above files.  If
  "Qt5Test" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  CMakeLists.txt:116 (find_package)


-- Configuring incomplete, errors occurred!
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-12-09 22:34:15 UTC
Is this failure conditional on any particular OPTIONS or does it fail in the global / default scope?
Comment 2 Eric Camachat 2021-12-09 22:52:15 UTC
Yes, seems I enabled DOCS option:
eric /u/p/a/marble (main)> make -V OPTIONS_DEFAULT
GPS WEBENGINE
eric /u/p/a/marble (main)> make -V SELECTED_OPTIONS
DOCS GPS WEBENGINE
eric /u/p/a/marble (main)>

I will verify is it depends on DOCS option.
Comment 3 Eric Camachat 2021-12-09 23:07:03 UTC
It's not DOCS option related, maybe it only happened on my machine because I have set some OPTIONS.

/u/p/a/marble (main)> make -V OPTIONS_SET
AESNI SSE SSE2 SSE3 SSSE3 SSE41 SSE42 AVX LTO VAAPI VDPAU OPENCL OSS PULSEAUDIO ALSA CUPS WAYLAND LZ4 ZSTD
Comment 4 Adriaan de Groot freebsd_committer freebsd_triage 2021-12-09 23:36:28 UTC
I just removed QTTest as a link-time-dependency from quazip, which is a dependency of marble. That probably drops it from the implicit dependencies of marble, leading to this issue. Strange, I thought I had pou'ed this.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-12-10 00:04:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8328ee460a15f460233601c2254ed277791224df

commit 8328ee460a15f460233601c2254ed277791224df
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2021-12-09 23:58:35 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2021-12-10 00:04:12 +0000

    astro/marble: fix build

    Qt testlib was implicitly a dependency for the build (tests are
    mandatory), not listed in the port. Dropping testlib from quazip
    changed the dependency tree.

    Not bumping PORTREVISION, because the after the previous bump
    it couldn't have built.

    PR:             260298
    Reported by:    Eric Camachat

 astro/marble/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Adriaan de Groot freebsd_committer freebsd_triage 2021-12-10 00:14:08 UTC
Protobuf is optional, for .. "Parsing of OSM PBF files." So that's a specialized Open Street Map function. It wasn't enabled / used before, and still isn't. The Qt testlib was the actual cause of the configure failure. (CMake is not super clear in cases like this, where one optional thing isn't found and it looks like that that is the cause).